Skip to content

Commit 98ffa22

Browse files
authored
Fix breaking issues in Auth and Browshot (#499)
* Fixed broken URL string creation in browshot feature * Rolling back change to skip env auth if no keys set - breaks KV setup * Allowing skip of env auth method whilst fixing breaking issue * Return empty list to ChainedTokenCredential * Liniting fix
1 parent 057b849 commit 98ffa22

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

msticpy/auth/azure_auth_core.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,8 +302,7 @@ def _build_chained_creds(
302302
raise MsticpyAzureConfigError(
303303
"At least one valid authentication method required."
304304
)
305-
306-
return ChainedTokenCredential(*[client for client in clients if client])
305+
return ChainedTokenCredential([client for client in clients if client]) # type: ignore
307306

308307

309308
class _AzCachedConnect:

msticpy/context/domain_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def screenshot(url: str, api_key: str = None) -> httpx.Response:
9494
)
9595
image_string = (
9696
f"https://api.browshot.com/api/v1/screenshot/thumbnail?id={bs_id}"
97-
"&zoom=50&key={bs_api_key}"
97+
f"&zoom=50&key={bs_api_key}"
9898
)
9999
# Wait until the screenshot is ready and keep user updated with progress
100100
print("Getting screenshot")

requirements-all.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ azure-mgmt-monitor>=2.0.0
1010
azure-mgmt-network>=2.7.0
1111
azure-mgmt-resource>=16.1.0
1212
azure-mgmt-resourcegraph>=8.0.0
13-
azure-mgmt-subscription>=1.0.0
13+
azure-mgmt-subscription>=3.0.0
1414
azure-storage-blob>=12.5.0
1515
bokeh>=1.4.0
1616
cryptography>=3.1

0 commit comments

Comments
 (0)