MpConfig edit throws error with invalid file path. (#395)

Author: ianhelle

msticpy/config/mp_config_edit.py

@@ -79,7 +79,6 @@ def __init__(
                 self.mp_conf_file.current_file = conf_filepath
         elif isinstance(settings, str):
             self.mp_conf_file = MpConfigFile(file=settings)
-            self.mp_conf_file.load_from_file(file=settings)
         else:
             self.mp_conf_file = MpConfigFile()
             self.mp_conf_file.load_default()

tests/config/test_mp_config_edit.py

@@ -140,9 +140,10 @@ def test_mp_edit_load_params():
         for key in orig_settings.keys():
             check.equal(orig_settings[key], mp_conf.mp_controls.mp_config[key])
 
-    # Test no existing MPConfig
+    # Test invalid file in MPConfig env and with file parameter.
+    # should load without exception
     with custom_mp_config(str(config_path)):
         os.environ["MSTICPYCONFIG"] = "./invalid_file.yaml"
-        with pytest.raises(ValueError):
-            with pytest.warns(UserWarning):
-                mp_conf = MpConfigEdit()
+        mp_conf = MpConfigEdit()
+
+        mp_conf = MpConfigEdit(settings="./invalid_file.yaml")