Skip to content

Commit 01c2562

Browse files
author
Paul van Brenk
committed
PR feedback
1 parent c299f15 commit 01c2562

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Nodejs/Product/Nodejs/NpmUI/PackageCatalogEntryViewModel.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ protected PackageCatalogEntryViewModel(
5555
public string Keywords { get; }
5656

5757
public bool IsInstalledLocally => !this.IsLocalInstallMissing && this.localVersion.HasValue;
58-
public bool IsLocalInstallOutOfDate => !this.IsLocalInstallMissing && this.localVersion.HasValue && this.localVersion < this.version;
58+
public bool IsLocalInstallOutOfDate => this.IsInstalledLocally && this.localVersion < this.version;
5959

6060
// Local install is missing if we expect a local install, but it's not there.
6161
// This means that if a package is not in the package.json, we don't report it missing.
62-
public bool IsLocalInstallMissing => this.localInstallMissing.HasValue && this.localInstallMissing.Value;
62+
public bool IsLocalInstallMissing => this.localInstallMissing == true;
6363
public string LocalVersion => this.localVersion?.ToString() ?? string.Empty;
6464

6565
public override string ToString()
@@ -81,7 +81,7 @@ public ReadOnlyPackageCatalogEntryViewModel(IPackage package, IPackage localInst
8181
(package.Keywords != null && package.Keywords.Any())
8282
? string.Join(", ", package.Keywords)
8383
: Resources.NoKeywordsInPackage,
84-
localInstall != null ? (SemverVersion?)localInstall.Version : null,
84+
localInstall?.Version,
8585
localInstall?.IsMissing
8686
)
8787
{

0 commit comments

Comments
 (0)