Skip to content

Commit 2d9ec04

Browse files
author
Armando Aguirre
committed
Addressed PR comments, Small fixes
1 parent ae617e8 commit 2d9ec04

File tree

16 files changed

+38
-104
lines changed

16 files changed

+38
-104
lines changed

‎Nodejs/Product/Nodejs/Nodejs.csproj‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -585,14 +585,6 @@
585585
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
586586
<IncludeInVSIX>true</IncludeInVSIX>
587587
</Content>
588-
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\TypeScriptVuejsApp.vstemplate" />
589-
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\.postcssrc.js" />
590-
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\favicon.ico" />
591-
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\index.html" />
592-
<ZipProject Include="ProjectTemplates\VuejsApp\.postcssrc.js" />
593-
<ZipProject Include="ProjectTemplates\VuejsApp\favicon.ico" />
594-
<ZipProject Include="ProjectTemplates\VuejsApp\index.html" />
595-
<ZipProject Include="ProjectTemplates\VuejsApp\VuejsApp.vstemplate" />
596588
<ZipItem Include="Templates\Files\JavaScriptVueComponent\JavaScriptVueComponent.vstemplate" />
597589
<ZipItem Include="Templates\Files\TypeScriptVueComponent\TypeScriptVueComponent.vstemplate" />
598590
<Content Include="Workspace\OpenFolderSchema.json">
@@ -649,20 +641,31 @@
649641
<ZipItem Include="Templates\Files\EmptyPug\EmptyPug.pug" />
650642
<Compile Include="SharedProject\CommonProjectNode.DiskMerger.cs" />
651643
<ZipItem Include="Templates\Files\TypeScriptJsConfig\jsconfig.json" />
652-
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\TypeScriptVuejsApp.njsproj" />
653644
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\.babelrc" />
645+
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\.postcssrc.js" />
654646
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\App.vue" />
647+
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\favicon.ico" />
655648
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\Home.vue" />
649+
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\index.html" />
650+
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\main.ts" />
656651
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\package.json" />
657652
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\README.md" />
653+
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\shims.d.ts" />
658654
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\tsconfig.json" />
655+
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\TypeScriptVuejsApp.njsproj" />
656+
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\TypeScriptVuejsApp.vstemplate" />
659657
<ZipProject Include="ProjectTemplates\VuejsApp\.babelrc" />
658+
<ZipProject Include="ProjectTemplates\VuejsApp\.postcssrc.js" />
660659
<ZipProject Include="ProjectTemplates\VuejsApp\App.vue" />
660+
<ZipProject Include="ProjectTemplates\VuejsApp\favicon.ico" />
661661
<ZipProject Include="ProjectTemplates\VuejsApp\Home.vue" />
662+
<ZipProject Include="ProjectTemplates\VuejsApp\index.html" />
663+
<ZipProject Include="ProjectTemplates\VuejsApp\main.js" />
662664
<ZipProject Include="ProjectTemplates\VuejsApp\package.json" />
663665
<ZipProject Include="ProjectTemplates\VuejsApp\README.md" />
664666
<ZipProject Include="ProjectTemplates\VuejsApp\VuejsApp.njsproj" />
665-
<ZipItem Include="Templates\Files\TypeScriptVueComponent\TypeScriptVueComponent.vue" />
667+
<ZipItem Include="Templates\Files\TypeScriptVueComponent\TypeScriptVueComponent.vue" />
668+
<ZipItem Include="Templates\Files\JavaScriptVueComponent\JavaScriptVueComponent.vue" />
666669
<None Include="Theme\contrast.vstheme">
667670
<SubType>Designer</SubType>
668671
</None>
@@ -1257,10 +1260,7 @@
12571260
<ZipItem Include="Templates\Files\TypeScriptJasmineUnitTest\UnitTest.ts" />
12581261
</ItemGroup>
12591262
<ItemGroup>
1260-
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\main.ts" />
1261-
<TypeScriptProject Include="ProjectTemplates\TypeScriptVuejsApp\shims.d.ts" />
1262-
<ZipProject Include="ProjectTemplates\VuejsApp\main.js" />
1263-
<ZipItem Include="Templates\Files\JavaScriptVueComponent\JavaScriptVueComponent.vue" />
1263+
12641264
</ItemGroup>
12651265
<PropertyGroup>
12661266
<!--

‎Nodejs/Product/Nodejs/ProjectTemplates/TypeScriptAzureWebApp/TypeScriptWebApp.vstemplate‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<NumberOfParentCategoriesToRollUp>1</NumberOfParentCategoriesToRollUp>
1313
<PromptForSaveOnCreation>true</PromptForSaveOnCreation>
1414
<PreviewImage>Preview.png</PreviewImage>
15-
<TemplateGroupID>Node.jss</TemplateGroupID>
15+
<TemplateGroupID>Node.js</TemplateGroupID>
1616
</TemplateData>
1717
<TemplateContent>
1818
<Project File="TypeScriptWebApp.njsproj" ReplaceParameters="true">

‎Nodejs/Product/Nodejs/ProjectTemplates/TypeScriptAzureWebRole/TypeScriptAzureWebRole.vstemplate‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<NumberOfParentCategoriesToRollUp>1</NumberOfParentCategoriesToRollUp>
1414
<PromptForSaveOnCreation>true</PromptForSaveOnCreation>
1515
<PreviewImage>Preview.png</PreviewImage>
16-
<TemplateGroupID>Node.jss</TemplateGroupID>
16+
<TemplateGroupID>Node.js</TemplateGroupID>
1717
</TemplateData>
1818
<TemplateContent>
1919
<Project File="TypeScriptWebApp.njsproj" ReplaceParameters="true">

‎Nodejs/Product/Nodejs/ProjectTemplates/TypeScriptVuejsApp/App.vue‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,4 @@
1717
</script>
1818

1919
<style>
20-
#app {
21-
font-family: 'Avenir', Helvetica, Arial, sans-serif;
22-
-webkit-font-smoothing: antialiased;
23-
-moz-osx-font-smoothing: grayscale;
24-
text-align: center;
25-
color: #2c3e50;
26-
margin-top: 60px;
27-
}
2820
</style>

‎Nodejs/Product/Nodejs/ProjectTemplates/TypeScriptVuejsApp/Home.vue‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,4 @@
1616

1717
<!-- Add "scoped" attribute to limit CSS to this component only -->
1818
<style scoped>
19-
h3 {
20-
margin: 40px 0 0;
21-
}
22-
23-
ul {
24-
list-style-type: none;
25-
padding: 0;
26-
}
27-
28-
li {
29-
display: inline-block;
30-
margin: 0 10px;
31-
}
32-
33-
a {
34-
color: #42b983;
35-
}
3619
</style>

‎Nodejs/Product/Nodejs/ProjectTemplates/TypeScriptVuejsApp/TypeScriptVuejsApp.njsproj‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,6 @@
2626
<ScriptArguments>serve</ScriptArguments>
2727
</PropertyGroup>
2828

29-
<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
30-
<DebugSymbols>true</DebugSymbols>
31-
</PropertyGroup>
32-
<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
33-
<DebugSymbols>true</DebugSymbols>
34-
</PropertyGroup>
35-
3629
<ItemGroup>
3730
<Content Include=".babelrc" />
3831
<Content Include="public\favicon.ico" />

‎Nodejs/Product/Nodejs/ProjectTemplates/TypeScriptVuejsApp/TypeScriptVuejsApp.vstemplate‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,14 @@
1111
<ProvideDefaultName>true</ProvideDefaultName>
1212
<NumberOfParentCategoriesToRollUp>1</NumberOfParentCategoriesToRollUp>
1313
<PromptForSaveOnCreation>true</PromptForSaveOnCreation>
14-
<PreviewImage>Preview.png</PreviewImage>
15-
<TemplateGroupID>Node.jss</TemplateGroupID>
14+
<TemplateGroupID>Node.js</TemplateGroupID>
1615
</TemplateData>
1716
<TemplateContent>
1817
<Project File="TypeScriptVuejsApp.njsproj" ReplaceParameters="true">
1918
<Folder Name="dist" />
2019
<Folder Name="public">
2120
<ProjectItem>favicon.ico</ProjectItem>
22-
<ProjectItem>index.html</ProjectItem>
21+
<ProjectItem ReplaceParameters="true">index.html</ProjectItem>
2322
</Folder>
2423
<Folder Name="src">
2524
<Folder Name="assets" />

‎Nodejs/Product/Nodejs/ProjectTemplates/TypeScriptVuejsApp/index.html‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
<!DOCTYPE html>
1+
<!DOCTYPE html>
22
<html>
3-
<head>
3+
<head>
44
<meta charset="utf-8">
55
<meta http-equiv="X-UA-Compatible" content="IE=edge">
66
<meta name="viewport" content="width=device-width,initial-scale=1.0">
77
<link rel="shortcut icon" href="<%= webpackConfig.output.publicPath %>favicon.ico">
8-
<title>vue2</title>
9-
</head>
10-
<body>
8+
<title>$projectname$</title>
9+
</head>
10+
<body>
1111
<noscript>
12-
<strong>We're sorry but vue2 doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
12+
<strong>We're sorry but $projectname$ doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
1313
</noscript>
1414
<div id="app"></div>
1515
<!-- built files will be auto injected -->
16-
</body>
16+
</body>
1717
</html>

‎Nodejs/Product/Nodejs/ProjectTemplates/TypeScriptVuejsApp/main.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ import App from './App.vue';
44
Vue.config.productionTip = true;
55

66
new Vue({
7-
render: h => h(App)
8-
}).$mount('#app')
7+
render: h => h(App)
8+
}).$mount('#app');

‎Nodejs/Product/Nodejs/ProjectTemplates/TypeScriptWebApp/NodejsWebApp.vstemplate‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<NumberOfParentCategoriesToRollUp>1</NumberOfParentCategoriesToRollUp>
1313
<PromptForSaveOnCreation>true</PromptForSaveOnCreation>
1414
<PreviewImage>Preview.png</PreviewImage>
15-
<TemplateGroupID>Node.jss</TemplateGroupID>
15+
<TemplateGroupID>Node.js</TemplateGroupID>
1616
</TemplateData>
1717
<TemplateContent>
1818
<Project File="NodejsWebApp.njsproj" ReplaceParameters="true">

0 commit comments

Comments
 (0)