Fix null reference when redirector is null.

Paul van Brenk · Paul van Brenk · commit 2f24f435b39e · 2018-04-06T13:52:04.000-07:00
diff --git a/Nodejs/Product/Nodejs/Workspace/ContextMenuProvider.cs b/Nodejs/Product/Nodejs/Workspace/ContextMenuProvider.cs
@@ -152,7 +152,6 @@ private async void ExecDynamic(WorkspaceVisualNodeBase node, uint nCmdID)
                 var filePath = ((IFileNode)node).FullPath;
                 if (TryGetCommand(nCmdID, filePath, out var commandName))
                 {
-
                     using (var npmController = this.CreateController(node.Workspace))
                     using (var commander = npmController.CreateNpmCommander())
                     {
diff --git a/Nodejs/Product/Npm/SPI/NpmCommand.cs b/Nodejs/Product/Npm/SPI/NpmCommand.cs
@@ -106,7 +106,7 @@ await NpmHelpers.ExecuteNpmCommandAsync(
                 cancelled = true;
             }
             OnCommandCompleted(this.Arguments, redirector?.HasErrors ?? false, cancelled);
-            return !redirector.HasErrors;
+            return redirector == null || !redirector.HasErrors; // return true when the command completed without errors, or redirector is null (which means we can't track)
         }
 
         private sealed class NpmCommandRedirector : Redirector

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,6 @@ private async void ExecDynamic(WorkspaceVisualNodeBase node, uint nCmdID)`
`152`	`152`	`var filePath = ((IFileNode)node).FullPath;`
`153`	`153`	`if (TryGetCommand(nCmdID, filePath, out var commandName))`
`154`	`154`	`{`
`155`		`-`
`156`	`155`	`using (var npmController = this.CreateController(node.Workspace))`
`157`	`156`	`using (var commander = npmController.CreateNpmCommander())`
`158`	`157`	`{`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ await NpmHelpers.ExecuteNpmCommandAsync(`
`106`	`106`	`cancelled = true;`
`107`	`107`	`}`
`108`	`108`	`OnCommandCompleted(this.Arguments, redirector?.HasErrors ?? false, cancelled);`
`109`		`- return !redirector.HasErrors;`
	`109`	`+ return redirector == null \|\| !redirector.HasErrors; // return true when the command completed without errors, or redirector is null (which means we can't track)`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`private sealed class NpmCommandRedirector : Redirector`