PR feedback

Author: Paul van Brenk

Build/Common.Build.targets

@@ -146,7 +146,7 @@
           DestinationFolder="$(CopyOutputsToPath)Symbols" />
 
     <Copy SourceFiles="@(SatelliteDllsProjectOutputGroupOutput)"
-          DestinationFiles="@(SatelliteDllsProjectOutputGroupOutput->'$(CopyOutputsToPath)UnsignedBinaries\%(TargetPath)')"
+          DestinationFolder="$(CopyOutputsToPath)UnsignedBinaries\%(SatelliteDllsProjectOutputGroupOutput.TargetDir)" 
           SkipUnchangedFiles="true" />
 
     <Copy SourceFiles="@(OutputBinariesToSign -> '$(OutputPath)%(filename)%(extension)')"

Nodejs/Product/Npm/Npm.csproj

@@ -155,14 +155,14 @@
     <Compile Include="SQLite\SQLite.cs" />
     <Compile Include="SQLite\SQLiteAsync.cs" />
   </ItemGroup>
-  <ItemGroup>
+  <ItemGroup Condition="$(VSTarget) == '14.0'">
     <EmbeddedResource Include="Resources.resx">
       <Generator>ResXFileCodeGenerator</Generator>
       <LastGenOutput>Resources.Designer.cs</LastGenOutput>
       <SubType>Designer</SubType>
     </EmbeddedResource>
   </ItemGroup>
-  <ItemGroup>
+  <ItemGroup Condition="$(VSTarget) == '15.0'">
     <EmbeddedResource Include="Resources.cs.resx" />
     <EmbeddedResource Include="Resources.de.resx" />
     <EmbeddedResource Include="Resources.en.resx">

Nodejs/Setup/BuildRelease.ps1

@@ -591,9 +591,8 @@ try {
                 submit_symbols "$project_name$spacename" "$buildnumber $($i.VSName) $config" "symbols" $i.symboldir $symbol_contacts
 
                 Write-Output "End symbol submission for $($i.VSName)"                
-            }
 
-            foreach ($i in $target_info) {
+                Write-Output "Begin Setup build for $($i.VSName)"
                 $target_msbuild_exe = msbuild-exe $i
                 $target_msbuild_options = msbuild-options $i
                 & $target_msbuild_exe $global_msbuild_options $target_msbuild_options `
@@ -607,6 +606,8 @@ try {
                     /p:SignedBinariesPath=$($i.signed_bindir) `
                     /p:RezipVSIXFiles=true `
                     $setup_swix_project
+
+                Write-Output "End Setup build for $($i.VSName)"
             }
 
             $jobs = @()