more pr feedback

Author: Paul van Brenk

Nodejs/Product/Nodejs/NodejsConstants.cs

@@ -80,6 +80,8 @@ public static bool ContainsNodeModulesOrBowerComponentsFolder(string path)
 
         private const string TestRootDataValueGuidString = "{FF41BE7F-6D8C-4D27-91D4-51E4233BC7E4}";
         public readonly static Guid TestRootDataValueGuid = new Guid(TestRootDataValueGuidString);
+
+        public const string TestRootDataValueName = nameof(TestRootDataValueName);
     }
 
     internal static class NodeProjectProperty

Nodejs/Product/Nodejs/Workspace/PackageJsonScannerFactory.cs

@@ -91,7 +91,7 @@ protected override Task<List<FileDataValue>> ComputeFileDataValuesAsync(string f
                 var testRoot = packageJson.TestRoot;
                 if (!string.IsNullOrEmpty(testRoot))
                 {
-                    fileDataValues.Add(new FileDataValue(NodejsConstants.TestRootDataValueGuid, "TestRoot", testRoot));
+                    fileDataValues.Add(new FileDataValue(NodejsConstants.TestRootDataValueGuid, NodejsConstants.TestRootDataValueName, testRoot));
                 }
 
                 return Task.FromResult(fileDataValues);

Nodejs/Product/Nodejs/Workspace/PackageJsonTestContainerDiscoverer.cs

@@ -74,7 +74,7 @@ private async Task AttemptUpdateAsync()
                     foreach (var dataValue in filesDataValues)
                     {
                         var rootFilePath = workspace.MakeRooted(dataValue.Key);
-                        var testRoot = dataValue.Value.Where(f => f.Name == "TestRoot").FirstOrDefault()?.Value;
+                        var testRoot = dataValue.Value.Where(f => f.Name == NodejsConstants.TestRootDataValueName).FirstOrDefault()?.Value;
 
                         if (!string.IsNullOrEmpty(testRoot))
                         {

Nodejs/Product/TestAdapter/TestAdapter.csproj

@@ -71,7 +71,7 @@
     <Compile Include="JavaScriptTestDiscoverer.cs" />
     <Compile Include="JavaScriptTestDiscoverer.TestFileEntry.cs" />
     <Compile Include="TestExecutorWorker.cs" />
-    <Compile Include="TestFrameworks\FrameworkDiscover.cs" />
+    <Compile Include="TestFrameworks\FrameworkDiscoverer.cs" />
     <Compile Include="JavaScriptTestCaseProperties.cs" />
     <Compile Include="TestFrameworks\NodejsTestInfo.cs" />
     <Compile Include="TestFrameworks\TestFramework.cs" />