Skip to content

Commit 4d506b6

Browse files
author
Paul van Brenk
committed
Remove typings code from project system since no longer used
1 parent ac58cac commit 4d506b6

File tree

2 files changed

+4
-64
lines changed

2 files changed

+4
-64
lines changed

Nodejs/Product/Nodejs/Project/NodejsFileNode.cs

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
1-
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
1+
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
22

3-
using System;
4-
using System.IO;
5-
using Microsoft.VisualStudioTools.Project;
6-
using Microsoft.VisualStudioTools;
7-
using Microsoft.VisualStudio.Imaging.Interop;
83
using Microsoft.VisualStudio.Imaging;
4+
using Microsoft.VisualStudio.Imaging.Interop;
5+
using Microsoft.VisualStudioTools.Project;
96

107
namespace Microsoft.NodejsTools.Project
118
{
@@ -16,23 +13,6 @@ public NodejsFileNode(NodejsProjectNode root, ProjectElement e)
1613
{
1714
}
1815

19-
protected override void OnParentSet(HierarchyNode parent)
20-
{
21-
if (this.ProjectMgr == null)
22-
{
23-
return;
24-
}
25-
26-
if (this.Url.EndsWith(NodejsConstants.TypeScriptDeclarationExtension, StringComparison.OrdinalIgnoreCase)
27-
&& this.Url.StartsWith(Path.Combine(this.ProjectMgr.ProjectFolder, @"typings\"), StringComparison.OrdinalIgnoreCase))
28-
{
29-
this.ProjectMgr.Site.GetUIThread().Invoke(() =>
30-
{
31-
this.IncludeInProject(true);
32-
});
33-
}
34-
}
35-
3616
protected override ImageMoniker CodeFileIconMoniker => KnownMonikers.JSScript;
3717

3818
internal override int IncludeInProject(bool includeChildren)

Nodejs/Product/Nodejs/Project/NodejsProjectNode.cs

Lines changed: 1 addition & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
1+
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
22

33
using System;
44
using System.Collections.Generic;
@@ -129,46 +129,6 @@ private void AddProjectImage(NodejsProjectImageName name, string resourceId)
129129
public override Guid SharedCommandGuid => Guids.NodejsCmdSet;
130130

131131
internal override string IssueTrackerUrl => NodejsConstants.IssueTrackerUrl;
132-
protected override void FinishProjectCreation(string sourceFolder, string destFolder)
133-
{
134-
foreach (var item in this.BuildProject.Items)
135-
{
136-
if (IsProjectTypeScriptSourceFile(item.EvaluatedInclude))
137-
{
138-
// Create the 'typings' folder
139-
var typingsFolder = Path.Combine(this.ProjectHome, "Scripts", "typings");
140-
if (!Directory.Exists(typingsFolder))
141-
{
142-
Directory.CreateDirectory(typingsFolder);
143-
}
144-
145-
// Deploy node.d.ts
146-
var nodeTypingsFolder = Path.Combine(typingsFolder, "node");
147-
if (!Directory.Exists(Path.Combine(nodeTypingsFolder)))
148-
{
149-
Directory.CreateDirectory(nodeTypingsFolder);
150-
}
151-
152-
var nodeFolder = ((OAProject)this.GetAutomationObject()).ProjectItems
153-
.AddFolder("Scripts").ProjectItems
154-
.AddFolder("typings").ProjectItems
155-
.AddFolder("node");
156-
157-
nodeFolder.ProjectItems.AddFromFileCopy(
158-
Path.Combine(
159-
Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location),
160-
"Scripts",
161-
"typings",
162-
"node",
163-
"node.d.ts"
164-
)
165-
);
166-
break;
167-
}
168-
}
169-
170-
base.FinishProjectCreation(sourceFolder, destFolder);
171-
}
172132

173133
protected override void AddNewFileNodeToHierarchy(HierarchyNode parentNode, string fileName)
174134
{

0 commit comments

Comments
 (0)