Merge pull request #1602 from paulvanbrenk/103gh

Give usefull error when Nodejs exe is corrupt

Author: paulvanbrenk

Nodejs/Product/PressAnyKey/PressAnyKey.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
 
 using System;
+using System.ComponentModel;
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
@@ -19,22 +20,49 @@ private static int Main(string[] args)
             }
 
             Console.Title = args[2];
-            var psi = new ProcessStartInfo(args[2], string.Join(" ", args.Skip(3).Select(arg => ProcessOutput.QuoteSingleArgument(arg))));
-            psi.UseShellExecute = false;
+            var psi = new ProcessStartInfo(args[2], string.Join(" ", args.Skip(3).Select(arg => ProcessOutput.QuoteSingleArgument(arg))))
+            {
+                UseShellExecute = false
+            };
 
-            var proc = Process.Start(psi);
-            File.WriteAllText(args[1], proc.Id.ToString());
-            proc.WaitForExit();
+            var exitCode = 0;
+            try
+            {
+                var proc = Process.Start(psi);
+                File.WriteAllText(args[1], proc.Id.ToString());
+                proc.WaitForExit();
+                exitCode = proc.ExitCode;
+            }
+            catch (Win32Exception)
+            {
+                Console.WriteLine("Failed to start process.");
+                Console.WriteLine("Probable cause is the Node.js exe is corrupt, please re-install.");
+                Console.WriteLine($"path: '{args[2]}'.");
+                exitCode = -1;
+            }
+
+            var shouldWait = true;
+
+            switch (args[0])
+            {
+                case "both":
+                    shouldWait = true;
+                    break;
+                case "normal":
+                    shouldWait = exitCode == 0;
+                    break;
+                case "abnormal":
+                    shouldWait = exitCode != 0;
+                    break;
+            }
 
-            if (args[0] == "both" ||
-                (proc.ExitCode == 0 && args[0] == "normal") ||
-                (proc.ExitCode != 0 && args[0] == "abnormal"))
+            if (shouldWait)
             {
                 Console.Write("Press any key to continue...");
                 Console.ReadKey();
             }
 
-            return proc.ExitCode;
+            return exitCode;
         }
     }
 }