Latest MOODLE_500_STABLE weekly release contains change that breaks oauth

[Syxton]

https://moodle.atlassian.net/browse/MDL-86802

Moodle version 2025041404.07
Causes 500 error when attempting to login through oauth/oidc

Here is the file change at issue:

[weilai-irl]

Hi @Syxton

I believe this issue was added to the wrong project. This project contains repository_office365 plugin, which is a third party repository plugin that allows users to add files from their OneDrive/SharePoint when using with other plugins in the Microsoft plugins set; the issue you reported is in repository_onedrive, which is party of Moodle core. This is a common confusion.

I'm closing this issue in this case.

Regards,
Lai

[Syxton]

@weilai-irl Actually I think this is the proper place. The change to core Moodle has caused an error in the auth/oidc plugin.

[weilai-irl]

Hi @Syxton

After some investigation, I think I got what you meant.

I think the actual change required is in the local_o365 plugin, at

o365-moodle/local/o365/classes/httpclient.php

Line 162 in f3b69d9

public function put($url, $params = [], $options = []): bool|string {

, where the local_o365/httpclient class extends the core curl class, and contains the old function declaration of put() function. PHP 8.x enforces strict method signature compatibility, causing this fatal error.

The auth_oidc plugin has an auth_oidc/httpclient class as well, which also extends the core curl class. However it doesn't overrides the put() function, so it's not affected.

I'll provide a solution in a PR and link it to this issue.

Regards,
Lai

[aspark21]

Yeah getting a fatal error when logging in -
Fatal error: Declaration of local_o365\httpclient::put($url, $params = [], $options = []): string|bool must be compatible with curl::put($url, $params = [], $options = [], $includeuserpwd = true) in /path/to/moodle/public/local/o365/classes/httpclient.php on line 162

[Syxton]

@weilai-irl I see that 5.1 got a new release. Is there a planned 5.0 release with some of the latest fixes? It is stopping sites from being able to update past 5.0.4+ 2025041404.06 (currently they are at 5.0.6+ 2025041406.02)