Changing CLI Scaleset size parameter to max_size. (#2293)

* Changing size parameter to max_size.

* Adding default param for clarity.

* FIxing param

* Setting size to 1.

* Adding comment.

* Trailing white spaces.

* Adding initialized_size param.

* Using initialized_at.

* Changing variable name.

Author: nharper285

src/cli/onefuzz/api.py

@@ -1393,8 +1393,9 @@ def _expand_scaleset_machine(
     def create(
         self,
         pool_name: primitives.PoolName,
-        size: int,
+        max_size: int,
         *,
+        initial_size: Optional[int] = 1,
         image: Optional[str] = None,
         vm_sku: Optional[str] = "Standard_D2s_v3",
         region: Optional[primitives.Region] = None,
@@ -1423,14 +1424,16 @@ def create(
 
         auto_scale = requests.AutoScaleOptions(
             min=min_instances,
-            max=size,
-            default=size,
+            max=max_size,
+            default=max_size,
             scale_out_amount=scale_out_amount,
             scale_out_cooldown=scale_out_cooldown,
             scale_in_amount=scale_in_amount,
             scale_in_cooldown=scale_in_cooldown,
         )
 
+        # Setting size=1 so that the scaleset is intialized with only 1 node.
+        # The default and max are defined above
         return self._req_model(
             "POST",
             models.Scaleset,
@@ -1439,7 +1442,7 @@ def create(
                 vm_sku=vm_sku,
                 image=image,
                 region=region,
-                size=size,
+                size=initial_size,
                 spot_instances=spot_instances,
                 ephemeral_os_disks=ephemeral_os_disks,
                 tags=tags,