support GroupQueryAttention #676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanshaw24
reviewed
Mar 22, 2024
| ), | ||
| ) | ||
|
|
||
| class TestCudaOps(unittest.TestCase): |
Collaborator
There was a problem hiding this comment.
In the future (or potentially even in this PR), we can separate our Python tests for CUDA by different ops (like we do for cpu tests). Otherwise, in the long term this file will get too long (GitHub is already not showing its preview by default on this PR because of file size).
nit: regardless, we should probably rename this file as it is already under test/cuda, so test_cudaops.py is redundant.
sayanshaw24
reviewed
Mar 22, 2024
Collaborator
sayanshaw24
left a comment
sayanshaw24
left a comment
There was a problem hiding this comment.
Could you add a C++ unit test for GroupQueryAttention as well under test/shared_test?
…st_key nor past_value. Runtime CUDA error when copying result from GPU to CPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support GroupQueryAttention