Apply feedback

Author: vraspar

mobile/examples/phi-3/ios/LocalLLM/LocalLLM.xcodeproj/project.pbxproj

@@ -422,8 +422,7 @@
 					"$(PROJECT_DIR)/LocalLLM/lib",
 				);
 				MARKETING_VERSION = 1.0;
-				"MTL_ENABLE_DEBUG_INFO[sdk=iphoneos*]" = "";
-				PRODUCT_BUNDLE_IDENTIFIER = ai.onnxruntime.genai.demo.LocalLL;
+				PRODUCT_BUNDLE_IDENTIFIER = ai.onnxruntime.genai.demo.LocalLLM;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
 				SWIFT_EMIT_LOC_STRINGS = YES;

mobile/examples/phi-3/ios/LocalLLM/LocalLLM/ContentView.swift

@@ -124,7 +124,7 @@ struct ContentView: View {
           promptProcRate)
       }
     }
-    .onReceive(NotificationCenter.default.publisher(for: NSNotification.Name("TokenGenerationError"))) { notification in
+    .onReceive(NotificationCenter.default.publisher(for: NSNotification.Name("GenAIError"))) { notification in
       if let userInfo = notification.userInfo, let error = userInfo["error"] as? String {
         errorMessage = error
         isGenerating = false

mobile/examples/phi-3/ios/LocalLLM/LocalLLM/GenAIGenerator.mm

@@ -7,7 +7,7 @@
 #include "ort_genai.h"
 #include "ort_genai_c.h"
 
-const size_t kMaxTokens = 64;
+const size_t kMaxTokens = 200;
 
 @interface GenAIGenerator () {
   std::unique_ptr<OgaModel> model;
@@ -34,7 +34,19 @@ - (void)setModelFolderPath:(NSString*)modelPath {
   @synchronized(self) {
     self->modelPath = [modelPath copy];
     NSLog(@"Model folder path set to: %@", modelPath);
-    [self loadModelFromPath];
+    
+    try {
+      [self loadModelFromPath];
+    } catch (const std::exception& e) {
+      NSString* errorMessage = [NSString stringWithUTF8String:e.what()];
+      NSLog(@"Error loading model: %@", errorMessage);
+      
+      // Notify the UI about the error
+      NSDictionary* errorInfo = @{@"error" : errorMessage};
+      dispatch_async(dispatch_get_main_queue(), ^{
+        [[NSNotificationCenter defaultCenter] postNotificationName:@"GenAIError" object:nil userInfo:errorInfo];
+      });
+    }
   }
 }
 
@@ -82,7 +94,6 @@ - (void)generate:(nonnull NSString*)input_user_question {
     NSLog(@"Starting token generation loop...");
 
     startTime = Clock::now();
-    firstTokenTime = Clock::now();
     generator->AppendTokenSequences(*sequences);
     while (!generator->IsDone()) {
       tokenStartTime = Clock::now();
@@ -142,7 +153,7 @@ - (void)generate:(nonnull NSString*)input_user_question {
     // Send error to the UI
     NSDictionary* errorInfo = @{@"error" : errorMessage};
     dispatch_async(dispatch_get_main_queue(), ^{
-      [[NSNotificationCenter defaultCenter] postNotificationName:@"TokenGenerationError" object:nil userInfo:errorInfo];
+      [[NSNotificationCenter defaultCenter] postNotificationName:@"GenAIError" object:nil userInfo:errorInfo];
     });
   }
 }