Choice of compiler warnings enabled for -Werror #8693
Unanswered
NathanielMcVicar
asked this question in
Other Q&A
Replies: 1 comment
-
Welcome to contribute your fixes. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi all. I was wondering if there were any motivations behind which warnings are enabled in the onnxruntime build. In our setup (mostly inheriting warnings from LLVM) on Linux I had to remove the following warnings to build onnxruntime without error: cast-qual, covered-switch-default, implicit-fallthrough, non-virtual-dtor, string-conversion, suggest-override. While some of these are matters of opinion, some are pretty fundamental/good practice. Thanks!
Beta Was this translation helpful? Give feedback.
All reactions