Skip to content

[Build] Pybind11 3.0 support #25681

@LecrisUT

Description

@LecrisUT

Describe the issue

When trying to build with pybind11 3.0, there is a flood of errors messages coming through mostly due to -Werror and such. It would be great if upstream can investigate this

Urgency

Blocks pybind11 3.0 update in Fedora

Target platform

Fedora

Build script

Fedora rebuild with pybind11 3.0 in https://copr.fedorainfracloud.org/coprs/lecris/pybind11-3.0/package/onnxruntime/

Error / output

A snippet of the error message

In file included from /builddir/build/BUILD/onnxruntime-1.20.1-build/onnxruntime-1.20.1/onnxruntime/python/onnxruntime_pybind.h:18,
                 from /builddir/build/BUILD/onnxruntime-1.20.1-build/onnxruntime-1.20.1/onnxruntime/python/onnxruntime_pybind_exceptions.h:6,
                 from /builddir/build/BUILD/onnxruntime-1.20.1-build/onnxruntime-1.20.1/onnxruntime/python/onnxruntime_pybind_state.cc:5:
In function ‘pybind11::detail::property_cpp_function_classic<onnxruntime::ModelMetadata, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::readonly<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > onnxruntime::ModelMetadata::*, 0>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > onnxruntime::ModelMetadata::*, pybind11::handle const&)pybind11::cpp_function’,
    inlined from ‘pybind11::detail::property_cpp_function_classic<onnxruntime::ModelMetadata, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::read<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > onnxruntime::ModelMetadata::*, 0>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > onnxruntime::ModelMetadata::*, pybind11::handle const&)pybind11::cpp_function’ at /usr/include/pybind11/pybind11.h:1779:32,
    inlined from ‘pybind11::class_<onnxruntime::ModelMetadata>::def_readwrite<onnxruntime::ModelMetadata, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, char [14]>(char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > onnxruntime::ModelMetadata::*, char const (&) [14])pybind11::class_<onnxruntime::ModelMetadata>&’ at /usr/include/pybind11/pybind11.h:2204:58,
    inlined from ‘onnxruntime::python::addObjectMethods(pybind11::module_&, std::function<void (onnxruntime::InferenceSession*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > > > > const&)>)’ at /builddir/build/BUILD/onnxruntime-1.20.1-build/onnxruntime-1.20.1/onnxruntime/python/onnxruntime_pybind_state.cc:1935:21:
/usr/include/pybind11/pybind11.h:1774:92: error: ‘SR.25857’ is used uninitialized [-Werror=uninitialized]
 1774 |         return cpp_function([pm](const T &c) -> const D & { return c.*pm; }, is_method(hdl));

Visual Studio Version

No response

GCC / Compiler Version

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildbuild issues; typically submitted using templatecontributions welcomeexternal contributions welcome

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions