Use ir.Attr value

Signed-off-by: Ganesan Ramalingam <[email protected]>

Author: gramalingam

onnxscript/_internal/converter.py

@@ -354,7 +354,7 @@ def _to_onnx_attr_ref(
             msg = f"Unsupported attribute type {pytype!r}."
             fail(info.msg(msg) if info else msg)
         attr_type = ir.AttributeType(ta.pytype_to_attrtype(pytype))
-        return ir.Attr(attrname, attr_type, None, val.value)
+        return ir.Attr(attrname, attr_type, None, val.value.name)
 
     def _to_onnx_var(
         self,
@@ -536,7 +536,7 @@ def _translate_attr(
             val = self._lookup(expr.id, self._source_of(expr))
             if isinstance(val, values.AttrRef):
                 attr_type = ir.AttributeType(ta.pytype_to_attrtype(val.typeinfo))
-                attr_ref = ir.Attr(attr_name, attr_type, None, val.value)
+                attr_ref = ir.Attr(attr_name, attr_type, None, val.value.name)
                 if attr_meta is not None and (attr_ref.type != attr_meta.type):
                     self.fail(
                         expr,
@@ -1459,7 +1459,7 @@ def _translate_function_signature_common(
                 attribute_type = ta.pytype_to_attrtype(typeinfo)
                 attr = ir.Attr(x.arg, ir.AttributeType(attribute_type), default_value, None)
                 self._current_fn.append_parameter(attr)
-                self._bind(x.arg, values.AttrRef(x.arg, typeinfo, self._source_of(x)))
+                self._bind(x.arg, values.AttrRef(attr, typeinfo, self._source_of(x)))
             else:
                 onnx_parameter = make_value(x.arg, typeinfo, self._source_of(x))
                 self._current_fn.append_parameter(onnx_parameter)

onnxscript/_internal/values.py

@@ -861,18 +861,18 @@ def __init__(self, info: sourceinfo.SourceInfo) -> None:
 
 class AttrRef(SymbolValue):
     def __init__(
-        self, attr_name: str, typeinfo: _GenericAlias, info: sourceinfo.SourceInfo
+        self, attr: ir.Attr, typeinfo: _GenericAlias, info: sourceinfo.SourceInfo
     ) -> None:
         """Initializes AttrRef.
 
         Arguments:
-            attr_name: name of the attribute-parameter
+            attr: An ir.Attr representing the attribute-parameter
             typeinfo: type annotation of the attribute.
                 op's attributes in ONNX are usually single type or list of single type.
             info: for debugging use.
         """
         super().__init__(info)
-        self.value = attr_name
+        self.value = attr
         self.typeinfo = typeinfo
         if not isinstance(typeinfo, (type, _GenericAlias)):
             # typing._GenericAlias for List[int] and List[str], etc.