warn

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Author: justinchuby

onnxscript/function_libs/torch_lib/registration.py

@@ -5,6 +5,7 @@
 from __future__ import annotations
 
 import re
+import warnings
 from typing import Any, Callable, Generator, Optional
 
 import onnxscript
@@ -43,15 +44,19 @@ def register(self, func: Any, name: str, *, complex: bool = False) -> None:
 
         if complex:
             if overloaded_function.complex:
-                raise ValueError(
-                    f"Complex overload for '{name}' already registered: {overloaded_function.complex}."
+                warnings.warn(
+                    f"Complex overload for '{name}' already registered: {overloaded_function.complex}.",
+                    stacklevel=3,
                 )
+                return
             overloaded_function.complex.append(func)
         else:
             if overloaded_function.overloads:
-                raise ValueError(
-                    f"Real overload for '{name}' already registered: {overloaded_function.overloads}."
+                warnings.warn(
+                    f"Real overload for '{name}' already registered: {overloaded_function.overloads}.",
+                    stacklevel=3,
                 )
+                return
             overloaded_function.overloads.append(func)
 
     def __getitem__(self, name):
@@ -101,7 +106,6 @@ def torch_op(
     *,
     registry: Optional[Registry] = None,
     trace_only: bool = False,
-    private: bool = False,
     complex: bool = False,
 ) -> Callable[[Callable], onnxscript.OnnxFunction | onnxscript.values.TracedOnnxFunction]:
     """Register a torch op.
@@ -113,8 +117,6 @@ def torch_op(
             i.e. "aten::relu" instead of "aten::relu.default".
         registry: Registry to register the function to. If None, the default registry is used.
         trace_only: Whether the function should only be traced and not compiled.
-        private: Whether the function is private (not directly exposed). It should
-            be true for all functions with names starting with "_".
         complex: Whether the function expects complex-valued inputs.
     """
     if registry is None:
@@ -134,8 +136,6 @@ def wrapper(
 
         assert registry is not None
         for name_ in _check_and_normalize_names(name):
-            if private:
-                continue
             registry.register(processed_func, name_, complex=complex)
         return processed_func