Code Review Feedback

brianrob · brianrob · commit 36c6428b2781 · 2026-01-13T10:48:51.000-08:00
diff --git a/src/TraceEvent/Stacks/Histogram.cs b/src/TraceEvent/Stacks/Histogram.cs
@@ -47,11 +47,11 @@ public void AddSample(StackSourceSample sample)
         /// <param name="bucket">The bucket to add to.</param>
         public void AddMetric(float metric, int bucket)
         {
-            Debug.Assert(0 <= bucket && bucket < Count);
+            Debug.Assert(0 <= bucket && bucket < Count, $"Bucket index is out of range. Bucket: {bucket}, Count: {Count}");
 
             if (m_buckets == null)
             {
-                // We're in single-bucket mode
+                // We have not expanded to multiple buckets yet
                 if (m_singleBucketNum < 0)
                 {
                     m_singleBucketNum = bucket;

Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,11 @@ public void AddSample(StackSourceSample sample)`
`47`	`47`	`/// <param name="bucket">The bucket to add to.</param>`
`48`	`48`	`public void AddMetric(float metric, int bucket)`
`49`	`49`	`{`
`50`		`- Debug.Assert(0 <= bucket && bucket < Count);`
	`50`	`+ Debug.Assert(0 <= bucket && bucket < Count, $"Bucket index is out of range. Bucket: {bucket}, Count: {Count}");`
`51`	`51`
`52`	`52`	`if (m_buckets == null)`
`53`	`53`	`{`
`54`		`- // We're in single-bucket mode`
	`54`	`+ // We have not expanded to multiple buckets yet`
`55`	`55`	`if (m_singleBucketNum < 0)`
`56`	`56`	`{`
`57`	`57`	`m_singleBucketNum = bucket;`