Add GC Heap Analyzer support to .nettrace files (#2216)

* Initial plan for issue

* Add MemoryAnalyzer to EventPipePerfViewData to enable Heap Analyzer for .nettrace files

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

* Move MemoryAnalyzer inside hasGC conditional block

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

* Fix MemoryAnalyzer.Open to support non-ETL formats and single-process files

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

* Fix Toolbox.GetClrProcesses to use full file path for non-clr modules

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

* Refactor code based on review feedback: use pattern matching and simplify path logic

Co-authored-by: marklio <529657+marklio@users.noreply.github.com>

* Remove unused bool hasClr variable, use out _ instead

Co-authored-by: marklio <529657+marklio@users.noreply.github.com>

* Update to C# version 8.0.

* EventPipe traces don't have a runtime module because they only contain managed loads.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Co-authored-by: marklio <529657+marklio@users.noreply.github.com>
Co-authored-by: Brian Robbins <brianrob@microsoft.com>

Author: 3 people

src/Directory.Build.props

@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <LangVersion>7.3</LangVersion>
+    <LangVersion>8.0</LangVersion>
     <Features>strict</Features>
   </PropertyGroup>
 

src/PerfView/HeapView/HeapView.cs

@@ -95,6 +95,17 @@ private Menu CreateMainMenu()
             return menu;
         }
 
+        private TraceLog GetTraceLog(StatusBar worker)
+        {
+            return m_dataFile switch
+            {
+                ETLPerfViewData etlDataFile => etlDataFile.GetTraceLog(worker.LogWriter),
+                LinuxPerfViewData linuxDataFile => linuxDataFile.GetTraceLog(worker.LogWriter),
+                EventPipePerfViewData eventPipeDataFile => eventPipeDataFile.GetTraceLog(worker.LogWriter),
+                _ => null,
+            };
+        }
+
         private void LaunchViewer(List<IProcess> selectedProcesses)
         {
             // Single process only
@@ -183,28 +194,36 @@ public override void Open(Window parentWindow, StatusBar worker, Action doAfter
             {
                 if (m_dataFile.SupportsProcesses)
                 {
-                    // Only ETL/ETLX file supported
-                    ETLPerfViewData etlDataFile = m_dataFile as ETLPerfViewData;
+                    // Get TraceLog from the data file (supports multiple formats)
+                    m_traceLog = GetTraceLog(worker);
 
-                    if (etlDataFile == null)
+                    if (m_traceLog != null)
                     {
-                        return;
-                    }
+                        m_worker = worker;
 
-                    m_traceLog = etlDataFile.GetTraceLog(worker.LogWriter);
+                        m_traceLog.SelectClrProcess(LaunchViewer);
+                    }
+                }
+                else
+                {
+                    // Single process format - get the process directly
+                    m_traceLog = GetTraceLog(worker);
 
                     if (m_traceLog != null)
                     {
                         m_worker = worker;
 
-                        m_traceLog.SelectClrProcess(LaunchViewer);
+                        var clrProcesses = m_traceLog.GetClrProcesses(out _);
+                        if (clrProcesses.Count > 0)
+                        {
+                            LaunchViewer(clrProcesses);
+                        }
                     }
                 }
             }
             else
             {
                 m_mainWindow.Focus();
-
                 doAfter?.Invoke();
             }
         }

src/PerfView/HeapView/Toolbox.cs

@@ -735,6 +735,7 @@ internal static bool IsClr(this string name)
         {
             return name.Equals("clr", StringComparison.OrdinalIgnoreCase) ||
                    name.Equals("coreclr", StringComparison.OrdinalIgnoreCase) ||
+                   name.Equals("libcoreclr", StringComparison.OrdinalIgnoreCase) ||
                    name.Equals("mscorwks", StringComparison.OrdinalIgnoreCase) ||
                    name.Equals("mrt100", StringComparison.OrdinalIgnoreCase);
         }
@@ -746,6 +747,8 @@ internal static bool IsMscorlib(this string name)
         {
             return name.Equals("mscorlib", StringComparison.OrdinalIgnoreCase) ||
                    name.Equals("mscorlib.ni", StringComparison.OrdinalIgnoreCase) ||
+                   name.Equals("system.private.corelib", StringComparison.OrdinalIgnoreCase) ||
+                   name.Equals("system.private.corelib.il", StringComparison.OrdinalIgnoreCase) ||
                    name.Equals("corefx", StringComparison.OrdinalIgnoreCase);
         }
 
@@ -775,8 +778,6 @@ internal static List<IProcess> GetClrProcesses(this TraceLog traceLog, out bool
                 {
                     foreach (TraceLoadedModule m in mods)
                     {
-                        keep = false;
-
                         string name = m.Name;
 
                         if (name.IsClr() || name.IsMscorlib() && String.IsNullOrEmpty(clrVersion))
@@ -787,19 +788,16 @@ internal static List<IProcess> GetClrProcesses(this TraceLog traceLog, out bool
                             {
                                 clrVersion = m.ModuleFile.FilePath;
 
-                                int pos = clrVersion.LastIndexOf('\\');
-
-                                if (pos > 0)
+                                // Only extract version from path for clr.dll, for other modules use full path
+                                if (name.Equals("clr", StringComparison.OrdinalIgnoreCase))
                                 {
-                                    int p = clrVersion.LastIndexOf('\\', pos - 1);
-
-                                    if (p > 0)
+                                    var parentDir = Path.GetDirectoryName(clrVersion);
+                                    if (!String.IsNullOrEmpty(parentDir))
                                     {
-                                        pos = p;
+                                        clrVersion = Path.GetFileName(parentDir);
                                     }
-
-                                    clrVersion = clrVersion.Substring(pos + 1);
                                 }
+                                // For non-clr modules, clrVersion is already set to the full file path above
                             }
 
                             hasClr = true;

src/PerfView/PerfViewData.cs

@@ -9564,6 +9564,7 @@ protected override Action<Action> OpenImpl(Window parentWindow, StatusBar worker
                 if (hasGC)
                 {
                     memory.AddChild(new PerfViewGCStats(this));
+                    memory.AddChild(new MemoryAnalyzer(this));
                 }
 
                 if (hasGCAllocationTicks)