Skip to content

Commit 8413bdc

Browse files
chore: enable Baseline Package Validation (#3169)
Co-authored-by: Julian Verdurmen <[email protected]>
1 parent 9d93d9c commit 8413bdc

File tree

7 files changed

+66
-1
lines changed

7 files changed

+66
-1
lines changed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
name: Validate NuGet Packages
2+
3+
on:
4+
push:
5+
branches:
6+
- main
7+
pull_request:
8+
branches:
9+
- main
10+
11+
jobs:
12+
build:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@v4
16+
- name: Setup .NET Core
17+
uses: actions/setup-dotnet@v4
18+
with:
19+
dotnet-version: 8.0.x
20+
- name: Download driver
21+
run: ./build.sh --download-driver
22+
- name: Validate NuGet packages
23+
run: dotnet pack ./src/Playwright.sln

src/Playwright.MSTest/Playwright.MSTest.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
<PackageOutputPath>./nupkg</PackageOutputPath>
2020
<IsPackable>true</IsPackable>
2121
<Nullable>enable</Nullable>
22+
<EnablePackageValidation>true</EnablePackageValidation>
23+
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
2224
</PropertyGroup>
2325

2426
<Import Project="../Common/Version.props" />

src/Playwright.NUnit/Playwright.NUnit.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
<PackageOutputPath>./nupkg</PackageOutputPath>
2020
<IsPackable>true</IsPackable>
2121
<Nullable>enable</Nullable>
22+
<EnablePackageValidation>true</EnablePackageValidation>
23+
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
2224
</PropertyGroup>
2325

2426
<Import Project="../Common/Version.props" />

src/Playwright.TestAdapter/Playwright.TestAdapter.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
<PackageOutputPath>./nupkg</PackageOutputPath>
1919
<IsPackable>true</IsPackable>
2020
<Nullable>enable</Nullable>
21+
<EnablePackageValidation>true</EnablePackageValidation>
22+
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
2123
</PropertyGroup>
2224

2325
<Import Project="../Common/Version.props" />

src/Playwright.Xunit/Playwright.Xunit.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
<PackageOutputPath>./nupkg</PackageOutputPath>
2020
<IsPackable>true</IsPackable>
2121
<Nullable>enable</Nullable>
22+
<EnablePackageValidation>true</EnablePackageValidation>
23+
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
2224
</PropertyGroup>
2325

2426
<Import Project="../Common/Version.props" />
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
3+
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
4+
<Suppression>
5+
<DiagnosticId>CP0002</DiagnosticId>
6+
<Target>M:Microsoft.Playwright.BindingSource.#ctor</Target>
7+
<Left>lib/netstandard2.0/Microsoft.Playwright.dll</Left>
8+
<Right>lib/netstandard2.0/Microsoft.Playwright.dll</Right>
9+
<IsBaselineSuppression>true</IsBaselineSuppression>
10+
</Suppression>
11+
<Suppression>
12+
<DiagnosticId>CP0002</DiagnosticId>
13+
<Target>M:Microsoft.Playwright.LocatorAriaSnapshotOptions.get_Ref</Target>
14+
<Left>lib/netstandard2.0/Microsoft.Playwright.dll</Left>
15+
<Right>lib/netstandard2.0/Microsoft.Playwright.dll</Right>
16+
<IsBaselineSuppression>true</IsBaselineSuppression>
17+
</Suppression>
18+
<Suppression>
19+
<DiagnosticId>CP0002</DiagnosticId>
20+
<Target>M:Microsoft.Playwright.LocatorAriaSnapshotOptions.set_Ref(System.Nullable{System.Boolean})</Target>
21+
<Left>lib/netstandard2.0/Microsoft.Playwright.dll</Left>
22+
<Right>lib/netstandard2.0/Microsoft.Playwright.dll</Right>
23+
<IsBaselineSuppression>true</IsBaselineSuppression>
24+
</Suppression>
25+
<Suppression>
26+
<DiagnosticId>CP0009</DiagnosticId>
27+
<Target>T:Microsoft.Playwright.BindingSource</Target>
28+
<Left>lib/netstandard2.0/Microsoft.Playwright.dll</Left>
29+
<Right>lib/netstandard2.0/Microsoft.Playwright.dll</Right>
30+
<IsBaselineSuppression>true</IsBaselineSuppression>
31+
</Suppression>
32+
</Suppressions>

src/Playwright/Playwright.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@
1717
<ReleaseVersion>0.0.0</ReleaseVersion>
1818
<BuildFromSource>True</BuildFromSource>
1919
<AnalysisMode>AllEnabledByDefault</AnalysisMode>
20-
<NoWarn>1701;1702;CS0067;1734;NU5110;NU5111</NoWarn>
20+
<NoWarn>1701;1702;CS0067;1734;NU5110;NU5111;CP0006</NoWarn>
2121
<AssemblyName>Microsoft.Playwright</AssemblyName>
2222
<NoWin32Manifest>true</NoWin32Manifest>
23+
<EnablePackageValidation>true</EnablePackageValidation>
24+
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
2325
<Nullable>enable</Nullable>
2426
</PropertyGroup>
2527
<Import Project="../Common/Version.props" />

0 commit comments

Comments
 (0)