chore: use abstract method in AssertionsBase (#3199)

mxschmitt · web-flow · commit e61cbed5a246 · 2025-07-09T11:03:00.000+02:00
diff --git a/src/Playwright/Core/AssertionsBase.cs b/src/Playwright/Core/AssertionsBase.cs
@@ -38,7 +38,7 @@
 
 namespace Microsoft.Playwright.Core;
 
-internal class AssertionsBase
+internal abstract class AssertionsBase
 {
     private static float _defaultTimeout = 5_000;
 
@@ -49,10 +49,7 @@ public AssertionsBase(bool isNot)
 
     protected bool IsNot { get; }
 
-    protected virtual Task<FrameExpectResult> CallExpectAsync(string expression, FrameExpectOptions expectOptions, string title)
-    {
-        throw new NotImplementedException("CallExpectAsync must be implemented in a derived class.");
-    }
+    protected abstract Task<FrameExpectResult> CallExpectAsync(string expression, FrameExpectOptions expectOptions, string title);
 
     protected async Task ExpectImplAsync(string expression, ExpectedTextValue textValue, object expected, string message, string title, FrameExpectOptions options)
     {

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@`
`38`	`38`
`39`	`39`	`namespace Microsoft.Playwright.Core;`
`40`	`40`
`41`		`-internal class AssertionsBase`
	`41`	`+internal abstract class AssertionsBase`
`42`	`42`	`{`
`43`	`43`	`private static float _defaultTimeout = 5_000;`
`44`	`44`
`@@ -49,10 +49,7 @@ public AssertionsBase(bool isNot)`
`49`	`49`
`50`	`50`	`protected bool IsNot { get; }`
`51`	`51`
`52`		`- protected virtual Task<FrameExpectResult> CallExpectAsync(string expression, FrameExpectOptions expectOptions, string title)`
`53`		`- {`
`54`		`- throw new NotImplementedException("CallExpectAsync must be implemented in a derived class.");`
`55`		`- }`
	`52`	`+ protected abstract Task<FrameExpectResult> CallExpectAsync(string expression, FrameExpectOptions expectOptions, string title);`
`56`	`53`
`57`	`54`	`protected async Task ExpectImplAsync(string expression, ExpectedTextValue textValue, object expected, string message, string title, FrameExpectOptions options)`
`58`	`55`	`{`