Skip to content

Commit 098b21f

Browse files
committed
chore: rename headful -> headed
This is how we call it everywhere else
1 parent fd2ab47 commit 098b21f

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

playwright/src/test/java/com/microsoft/playwright/TestBase.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ public class TestBase {
4545
static final boolean isMac = Utils.getOS() == Utils.OS.MAC;
4646
static final boolean isLinux = Utils.getOS() == Utils.OS.LINUX;
4747
static final boolean isWindows = Utils.getOS() == Utils.OS.WINDOWS;
48-
static final boolean headful;
48+
static final boolean headed;
4949
static final SameSiteAttribute defaultSameSiteCookieValue;
5050

5151
static {
52-
String headfulEnv = System.getenv("HEADFUL");
53-
headful = headfulEnv != null && !"0".equals(headfulEnv) && !"false".equals(headfulEnv);
52+
String headedEnv = System.getenv("HEADED");
53+
headed = headedEnv != null && !"0".equals(headedEnv) && !"false".equals(headedEnv);
5454
defaultSameSiteCookieValue = initSameSiteAttribute();
5555
}
5656

@@ -59,7 +59,7 @@ public class TestBase {
5959
BrowserContext context;
6060

6161
static boolean isHeadful() {
62-
return headful;
62+
return headed;
6363
}
6464

6565
static boolean isChromium() {
@@ -81,7 +81,7 @@ static String getBrowserChannelFromEnv() {
8181
static BrowserType.LaunchOptions createLaunchOptions() {
8282
BrowserType.LaunchOptions options;
8383
options = new BrowserType.LaunchOptions();
84-
options.headless = !headful;
84+
options.headless = !headed;
8585
options.channel = getBrowserChannelFromEnv();
8686
return options;
8787
}

playwright/src/test/java/com/microsoft/playwright/TestDefaultBrowserContext2.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ void shouldSupportIgnoreHTTPSErrorsOption() {
128128

129129
@Test
130130
void shouldSupportExtraHTTPHeadersOption() throws ExecutionException, InterruptedException {
131-
// TODO: test.flaky(browserName === "firefox" && headful && platform === "linux", "Intermittent timeout on bots");
131+
// TODO: test.flaky(browserName === "firefox" && headed && platform === "linux", "Intermittent timeout on bots");
132132
Page page = launchPersistent(new BrowserType.LaunchPersistentContextOptions().setExtraHTTPHeaders(mapOf("foo", "bar")));
133133
Future<Server.Request> request = server.futureRequest("/empty.html");
134134
page.navigate(server.EMPTY_PAGE);

playwright/src/test/java/com/microsoft/playwright/TestDownload.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ static boolean isChromiumHeadful() {
348348
@Test
349349
@DisabledIf(value="isChromiumHeadful", disabledReason="fixme")
350350
void shouldReportNewWindowDownloads() throws IOException {
351-
// TODO: - the test fails in headful Chromium as the popup page gets closed along
351+
// TODO: - the test fails in headed Chromium as the popup page gets closed along
352352
// with the session before download completed event arrives.
353353
// - WebKit doesn't close the popup page
354354
Page page = browser.newPage(new Browser.NewPageOptions().setAcceptDownloads(true));

playwright/src/test/java/com/microsoft/playwright/TestOptionsFactories.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ public static BrowserType.LaunchOptions createLaunchOptions() {
4040
}
4141

4242
private static boolean getHeadful() {
43-
String headfulEnv = System.getenv("HEADFUL");
44-
return headfulEnv != null && !"0".equals(headfulEnv) && !"false".equals(headfulEnv);
43+
String headedEnv = System.getenv("HEADED");
44+
return headedEnv != null && !"0".equals(headedEnv) && !"false".equals(headedEnv);
4545
}
4646

4747
public static String getBrowserName() {

playwright/src/test/java/com/microsoft/playwright/TestPageScreenshot.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
import static org.junit.jupiter.api.Assertions.*;
4141
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
4242

43-
// TODO: suite.skip(browserName === "firefox" && headful");
43+
// TODO: suite.skip(browserName === "firefox" && headed");
4444
public class TestPageScreenshot extends TestBase {
4545
@Test
4646
void shouldWork() throws IOException {

playwright/src/test/java/com/microsoft/playwright/TestRequestFulfill.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ void shouldAllowMockingBinaryResponses() {
8787
@Test
8888
@DisabledIf(value="isFirefoxHeadful", disabledReason="skip")
8989
void shouldAllowMockingSvgWithCharset() {
90-
// Firefox headful produces a different image.
90+
// Firefox headed produces a different image.
9191
page.route("**/*", route -> {
9292
route.fulfill(new Route.FulfillOptions()
9393
.setContentType("image/svg+xml ; charset=utf-8")

0 commit comments

Comments
 (0)