1.54.0-alpha-2025-07-08

Author: Skn0tt

playwright/src/main/java/com/microsoft/playwright/ConsoleMessage.java

@@ -16,6 +16,7 @@
 
 package com.microsoft.playwright;
 
+import com.microsoft.playwright.options.*;
 import java.util.*;
 
 /**
@@ -77,6 +78,6 @@ public interface ConsoleMessage {
    *
    * @since v1.8
    */
-  String type();
+  ConsoleMessageType type();
 }
 

playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java

@@ -506,7 +506,7 @@ private void routeWebSocketImpl(UrlMatcher matcher, Consumer<WebSocketRoute> han
 
   void recordIntoHar(PageImpl page, Path har, RouteFromHAROptions options, HarContentPolicy contentPolicy) {
     if (contentPolicy == null) {
-      contentPolicy = Utils.convertType(options.updateContent, HarContentPolicy.class);;
+      contentPolicy = Utils.convertType(options.updateContent, HarContentPolicy.class);
     }
     if (contentPolicy == null) {
       contentPolicy = HarContentPolicy.ATTACH;

playwright/src/main/java/com/microsoft/playwright/impl/ConsoleMessageImpl.java

@@ -21,6 +21,7 @@
 import com.microsoft.playwright.ConsoleMessage;
 import com.microsoft.playwright.JSHandle;
 import com.microsoft.playwright.Page;
+import com.microsoft.playwright.options.ConsoleMessageType;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -43,8 +44,8 @@ public ConsoleMessageImpl(Connection connection, JsonObject initializer) {
     this.initializer = initializer;
   }
 
-  public String type() {
-    return initializer.get("type").getAsString();
+  public ConsoleMessageType type() {
+    return Utils.convertType(initializer.get("type").getAsString(), ConsoleMessageType.class);
   }
 
   public String text() {

playwright/src/main/java/com/microsoft/playwright/impl/FrameImpl.java

@@ -993,7 +993,8 @@ ElementHandle waitForSelectorImpl(String selector, WaitForSelectorOptions option
   @Override
   public void waitForTimeout(double timeout) {
     JsonObject params = new JsonObject();
-    sendMessage("waitForTimeout", params, timeout);
+    params.addProperty("waitTimeout", timeout);
+    sendMessage("waitForTimeout", params, NO_TIMEOUT);
   }
 
   @Override

playwright/src/main/java/com/microsoft/playwright/impl/SelectorsImpl.java

@@ -68,6 +68,10 @@ public void register(String name, Path path, RegisterOptions options) {
   }
 
   private void registerImpl(String name, String script, RegisterOptions options) {
+    if (selectorEngines.stream().anyMatch(engine -> name.equals(engine.get("name").getAsString()))) {
+      throw new PlaywrightException("selectors.register: \"" + name + "\" selector engine has been already registered");
+    }
+
     JsonObject engine = new JsonObject();
     engine.addProperty("name", name);
     engine.addProperty("source", script);

playwright/src/main/java/com/microsoft/playwright/impl/WebSocketRouteImpl.java

@@ -128,7 +128,11 @@ void afterHandle() {
       return;
     }
     // Ensure that websocket is "open" and can send messages without an actual server connection.
-    sendMessageAsync("ensureOpened");
+    try {
+      sendMessageAsync("ensureOpened");
+    } catch (PlaywrightException e) {
+      // If this happens after the page has been closed, ignore the error.
+    }
   }
 
   @Override

playwright/src/main/java/com/microsoft/playwright/options/ConsoleMessageType.java

@@ -0,0 +1,38 @@
+/*
+ * Copyright (c) Microsoft Corporation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.microsoft.playwright.options;
+
+public enum ConsoleMessageType {
+  LOG,
+  DEBUG,
+  INFO,
+  ERROR,
+  WARNING,
+  DIR,
+  DIRXML,
+  TABLE,
+  TRACE,
+  CLEAR,
+  STARTGROUP,
+  STARTGROUPCOLLAPSED,
+  ENDGROUP,
+  ASSERT,
+  PROFILE,
+  PROFILEEND,
+  COUNT,
+  TIMEEND
+}

playwright/src/test/java/com/microsoft/playwright/TestPageAriaSnapshot.java

@@ -3,6 +3,7 @@
 import com.microsoft.playwright.junit.FixtureTest;
 import com.microsoft.playwright.junit.UsePlaywright;
 import org.junit.jupiter.api.Test;
+import org.opentest4j.AssertionFailedError;
 
 import java.util.Arrays;
 import java.util.List;
@@ -12,6 +13,7 @@
 
 import static com.microsoft.playwright.assertions.PlaywrightAssertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 @FixtureTest
 @UsePlaywright
@@ -102,4 +104,27 @@ void shouldMatchUrl(Page page) {
       "- link:\n" +
       "  - /url: /.*example.com/");
   }
+
+  @Test
+  void shouldHandleTopLevelDeepEqual(Page page) {
+    // https://github.com/microsoft/playwright/issues/36456
+    page.setContent("" +
+      "<ul>\n" +
+      "  <li>\n" +
+      "    <ul>\n" +
+      "      <li>1.1</li>\n" +
+      "      <li>1.2</li>\n" +
+      "    </ul>\n" +
+      "  </li>\n" +
+      "</ul>");
+
+    assertThrows(AssertionFailedError.class, () -> {
+      assertThat(page.locator("body")).matchesAriaSnapshot("" +
+        "- /children: deep-equal\n" +
+        "- list:\n" +
+        "  - listitem:\n" +
+        "    - listitem: \"1.1\"\n" +
+        "    - listitem: \"1.2\"");
+    });
+  }
 }

playwright/src/test/java/com/microsoft/playwright/TestPageInterception.java

@@ -199,11 +199,14 @@ void shouldWorkWithGlob() {
     assertTrue(urlMatches("http://first.host/", "http://second.host/foo", "**/foo"));
     assertTrue(urlMatches("http://playwright.dev/", "http://localhost/", "*//localhost/"));
 
-    assertTrue(urlMatches("http://playwright.dev/", "about:blank", "about:blank"));
-    assertFalse(urlMatches("http://playwright.dev/", "about:blank", "http://playwright.dev/"));
-    assertTrue(urlMatches(null, "about:blank", "about:blank"));
-    assertTrue(urlMatches(null, "about:blank", "about:*"));
-    assertFalse(urlMatches(null, "notabout:blank", "about:*"));
+    String[] customPrefixes = {"about", "data", "chrome", "edge", "file"};
+    for (String prefix : customPrefixes) {
+      assertTrue(urlMatches("http://playwright.dev/", prefix + ":blank", prefix + ":blank"));
+      assertFalse(urlMatches("http://playwright.dev/", prefix + ":blank", "http://playwright.dev/"));
+      assertTrue(urlMatches(null, prefix + ":blank", prefix + ":blank"));
+      assertTrue(urlMatches(null, prefix + ":blank", prefix + ":*"));
+      assertFalse(urlMatches(null, "not" + prefix + ":blank", prefix + ":*"));
+    }
   }
 
   Pattern globToRegex(String glob) {

playwright/src/test/java/com/microsoft/playwright/TestSelectorsRegister.java

@@ -23,25 +23,26 @@
 import static org.junit.jupiter.api.Assertions.*;
 
 public class TestSelectorsRegister extends TestBase {
+  private static final String TAG_SELECTOR_SCRIPT = "{\n" +
+    "  create(root, target) {\n" +
+    "    return target.nodeName;\n" +
+    "  },\n" +
+    "  query(root, selector) {\n" +
+    "    return root.querySelector(selector);\n" +
+    "  },\n" +
+    "  queryAll(root, selector) {\n" +
+    "    return Array.from(root.querySelectorAll(selector));\n" +
+    "  }\n" +
+    "}";
+
   @Test
   void shouldWork() {
-    String selectorScript = "{\n" +
-      "  create(root, target) {\n" +
-      "    return target.nodeName;\n" +
-      "  },\n" +
-      "  query(root, selector) {\n" +
-      "    return root.querySelector(selector);\n" +
-      "  },\n" +
-      "  queryAll(root, selector) {\n" +
-      "    return Array.from(root.querySelectorAll(selector));\n" +
-      "  }\n" +
-      "}";
     // Register one engine before creating context.
-    playwright.selectors().register("tag", selectorScript);
+    playwright.selectors().register("tag", TAG_SELECTOR_SCRIPT);
 
     BrowserContext context = browser.newContext();
     // Register another engine after creating context.
-    playwright.selectors().register("tag2", selectorScript);
+    playwright.selectors().register("tag2", TAG_SELECTOR_SCRIPT);
 
     Page page = context.newPage();
     page.setContent("<div><span></span></div><div></div>");
@@ -134,4 +135,19 @@ void shouldHandleErrors() {
     });
     assertTrue(e.getMessage().contains("\"css\" is a predefined selector engine"));
   }
+
+  @Test
+  void shouldThrowAlreadyRegisteredErrorWhenRegistering() {
+    // https://github.com/microsoft/playwright/issues/36467
+    browser.close();
+
+    // Register the selector engine first
+    playwright.selectors().register("alreadyRegistered", TAG_SELECTOR_SCRIPT);
+    
+    // Attempt to register the same selector engine again should throw an error
+    PlaywrightException e = assertThrows(PlaywrightException.class, () -> {
+      playwright.selectors().register("alreadyRegistered", TAG_SELECTOR_SCRIPT);
+    });
+    assertTrue(e.getMessage().contains("\"alreadyRegistered\" selector engine has been already registered"));
+  }
 }