fix: do not fail on a bad file name in stack trace (#1120)

yury-s · web-flow · commit 1674f95bd186 · 2022-11-11T18:42:11.000-08:00
diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/StackTraceCollector.java b/playwright/src/main/java/com/microsoft/playwright/impl/StackTraceCollector.java
@@ -69,7 +69,13 @@ private String sourceFile(StackTraceElement frame) {
     if (file == null) {
       return "";
     }
-    return resolveSourcePath(Paths.get(pkg).resolve(file));
+    try {
+      // The file name can contain an arbitrary string which may cause Path implementation
+      // to throw. See https://github.com/microsoft/playwright-java/issues/1115
+      return resolveSourcePath(Paths.get(pkg).resolve(file));
+    } catch (RuntimeException e) {
+      return "";
+    }
   }
 
   private String resolveSourcePath(Path relativePath) {

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,13 @@ private String sourceFile(StackTraceElement frame) {`
`69`	`69`	`if (file == null) {`
`70`	`70`	`return "";`
`71`	`71`	`}`
`72`		`- return resolveSourcePath(Paths.get(pkg).resolve(file));`
	`72`	`+ try {`
	`73`	`+ // The file name can contain an arbitrary string which may cause Path implementation`
	`74`	`+ // to throw. See https://github.com/microsoft/playwright-java/issues/1115`
	`75`	`+ return resolveSourcePath(Paths.get(pkg).resolve(file));`
	`76`	`+ } catch (RuntimeException e) {`
	`77`	`+ return "";`
	`78`	`+ }`
`73`	`79`	`}`
`74`	`80`
`75`	`81`	`private String resolveSourcePath(Path relativePath) {`