Skip to content

Commit 3c925b1

Browse files
committed
test: add classloader docker ci test
1 parent 2b8f04d commit 3c925b1

File tree

4 files changed

+19
-243
lines changed

4 files changed

+19
-243
lines changed

.github/workflows/test_docker.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,9 @@ jobs:
3636
run: |
3737
CONTAINER_ID="$(docker run --rm -e CI --ipc=host -v $(pwd):/root/playwright --name playwright-docker-test -d -t playwright-java:localbuild-${{ matrix.flavor }} /bin/bash)"
3838
docker exec "${CONTAINER_ID}" /root/playwright/tools/test-local-installation/create_project_and_run_tests.sh
39+
- name: Test ClassLoader
40+
env:
41+
BROWSER: ${{ matrix.browser }}
42+
run: |
43+
CONTAINER_ID="$(docker run --rm -e CI --ipc=host -v $(pwd):/root/playwright --name playwright-docker-test -d -t playwright-java:localbuild-${{ matrix.flavor }} /bin/bash)"
44+
docker exec "${CONTAINER_ID}" /root/playwright/tools/test-spring-classloader/package_and_run_classloader_test.sh
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
#!/bin/bash
2+
3+
set -e
4+
set +x
5+
6+
cd "$(dirname "$0")"
7+
mvn package -D skipTests --no-transfer-progress
8+
java -jar target/test-spring-classloader*.jar

tools/test-spring-classloader/src/main/java/com/microsoft/playwright/springboottest/DriverJar.java

Lines changed: 0 additions & 209 deletions
This file was deleted.

tools/test-spring-classloader/src/main/java/com/microsoft/playwright/springboottest/TestApp.java

Lines changed: 5 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ public static void main(String[] args) {
1515
}
1616

1717
public void run(String... args) {
18-
System.out.println("Starting original Playwright test...");
18+
// use CompletableFuture to run Playwright asynchronously
1919
CompletableFuture<Void> voidCompletableFuture = CompletableFuture.runAsync(() -> {
2020
try (Playwright playwright = Playwright.create()) {
21-
System.out.println("original Playwright test started, waiting for completion...");
21+
System.out.println("Playwright classLoader test started, waiting for completion...");
2222
BrowserType browserType = getBrowserTypeFromEnv(playwright);
23-
System.out.println("Running original test with " + browserType.name());
23+
System.out.println("Running test with " + browserType.name());
2424
Browser browser = browserType.launch();
2525
BrowserContext context = browser.newContext();
2626
Page page = context.newPage();
@@ -33,40 +33,11 @@ public void run(String... args) {
3333
}
3434
});
3535

36-
System.out.println("original Playwright test is running asynchronously, main thread will wait for it to complete.");
36+
System.out.println("Playwright classLoader test is running asynchronously, main thread will wait for it to complete.");
3737

3838
voidCompletableFuture.join();
3939

40-
System.out.println("original Playwright test completed.");
41-
42-
43-
System.out.println("Starting new Playwright test...");
44-
45-
// Set the new driver implementation to use the DriverJar class
46-
System.setProperty( "playwright.driver.impl", "com.microsoft.playwright.springboottest.DriverJar" );
47-
48-
CompletableFuture<Void> voidCompletableFuture2 = CompletableFuture.runAsync(() -> {
49-
try (Playwright playwright = Playwright.create()) {
50-
System.out.println("new Playwright test started, waiting for completion...");
51-
BrowserType browserType = getBrowserTypeFromEnv(playwright);
52-
System.out.println("Running new test with " + browserType.name());
53-
Browser browser = browserType.launch();
54-
BrowserContext context = browser.newContext();
55-
Page page = context.newPage();
56-
System.out.println(page.evaluate("'SUCCESS: did evaluate in page'"));
57-
} catch (Exception e) {
58-
System.out.println("FAILED: " + e.toString());
59-
for (StackTraceElement ste : e.getStackTrace()) {
60-
System.out.println("\tat " + ste);
61-
}
62-
}
63-
});
64-
65-
System.out.println("new Playwright test is running asynchronously, main thread will wait for it to complete.");
66-
67-
voidCompletableFuture2.join();
68-
69-
System.out.println("new Playwright test completed.");
40+
System.out.println("Playwright classLoader test completed.");
7041

7142
}
7243

0 commit comments

Comments
 (0)