review feedback

Author: mxschmitt

examples/pom.xml

@@ -10,13 +10,13 @@
   <name>Playwright Client Examples</name>
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <playwright-version>1.49.0</playwright-version>
+    <playwright.version>1.49.0</playwright.version>
   </properties>
   <dependencies>
     <dependency>
       <groupId>com.microsoft.playwright</groupId>
       <artifactId>playwright</artifactId>
-      <version>${playwright-version}</version>
+      <version>${playwright.version}</version>
     </dependency>
   </dependencies>
   <build>

scripts/set_maven_version.sh

@@ -21,11 +21,11 @@ POM_FILES=(
 )
 
 node -e "$(cat <<EOF
-  const parts = process.argv[1].split('.').map(part => parseInt(part, 10));
+  const parts = process.argv[1].split('-')[0].split('.').map(part => parseInt(part, 10));
   parts[1]--;
   const previousMajorVersion = parts.join('.');
   fs.writeFileSync('examples/pom.xml', fs.readFileSync('examples/pom.xml', 'utf8')
-    .replace(/<playwright-version>.*<\/playwright-version>/, '<playwright-version>' + previousMajorVersion + '</playwright-version>')
+    .replace(/<playwright\.version>.*<\/playwright\.version>/, '<playwright\.version>' + previousMajorVersion + '</playwright\.version>')
   );
 EOF
 )" $VERSION