Skip to content

Commit 4762ad9

Browse files
khmarbaisekhmarbaise
authored
devops: Improve plugin configuration inheritance usage (#1201) (#1202)
devops: Improve plugin configuration inheritance usage. (#1201) - removing duplication of plugin definition in modules - using single location to define all (parent) - defined all used plugins via pluginManagement with most recent versions. - removed life cycle binding from pluginManagement - moved life cycle binding to default location - using jar-no-fork of maven-source-plugin.
1 parent 0fb77bb commit 4762ad9

File tree

4 files changed

+46
-64
lines changed

4 files changed

+46
-64
lines changed

‎driver-bundle/pom.xml‎

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,25 +16,6 @@
1616
It is intended to be used on the systems where Playwright driver is not preinstalled.
1717
</description>
1818

19-
<build>
20-
<plugins>
21-
<plugin>
22-
<groupId>org.apache.maven.plugins</groupId>
23-
<artifactId>maven-source-plugin</artifactId>
24-
<configuration>
25-
<excludeResources>true</excludeResources>
26-
</configuration>
27-
</plugin>
28-
<plugin>
29-
<groupId>org.apache.maven.plugins</groupId>
30-
<artifactId>maven-javadoc-plugin</artifactId>
31-
</plugin>
32-
<plugin>
33-
<groupId>org.apache.maven.plugins</groupId>
34-
<artifactId>maven-surefire-plugin</artifactId>
35-
</plugin>
36-
</plugins>
37-
</build>
3819
<dependencies>
3920
<dependency>
4021
<groupId>com.microsoft.playwright</groupId>

‎driver/pom.xml‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@
1515
This module provides API for discovery and launching of Playwright driver.
1616
</description>
1717

18-
<build>
19-
<plugins>
20-
<plugin>
21-
<groupId>org.apache.maven.plugins</groupId>
22-
<artifactId>maven-source-plugin</artifactId>
23-
</plugin>
24-
<plugin>
25-
<groupId>org.apache.maven.plugins</groupId>
26-
<artifactId>maven-javadoc-plugin</artifactId>
27-
</plugin>
28-
<plugin>
29-
<groupId>org.apache.maven.plugins</groupId>
30-
<artifactId>maven-surefire-plugin</artifactId>
31-
</plugin>
32-
</plugins>
33-
</build>
3418
<dependencies>
3519
<dependency>
3620
<groupId>org.junit.jupiter</groupId>

‎playwright/pom.xml‎

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,26 +21,14 @@
2121

2222
<build>
2323
<plugins>
24-
<plugin>
25-
<groupId>org.apache.maven.plugins</groupId>
26-
<artifactId>maven-source-plugin</artifactId>
27-
</plugin>
2824
<plugin>
2925
<groupId>org.apache.maven.plugins</groupId>
3026
<artifactId>maven-javadoc-plugin</artifactId>
31-
<configuration>
27+
<configuration combine.self="append">
3228
<subpackages>com.microsoft.playwright</subpackages>
3329
<excludePackageNames>com.microsoft.playwright.impl</excludePackageNames>
3430
</configuration>
3531
</plugin>
36-
<plugin>
37-
<groupId>org.apache.maven.plugins</groupId>
38-
<artifactId>maven-compiler-plugin</artifactId>
39-
</plugin>
40-
<plugin>
41-
<groupId>org.apache.maven.plugins</groupId>
42-
<artifactId>maven-surefire-plugin</artifactId>
43-
</plugin>
4432
<plugin>
4533
<groupId>org.apache.maven.plugins</groupId>
4634
<artifactId>maven-jar-plugin</artifactId>

‎pom.xml‎

Lines changed: 45 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -91,22 +91,35 @@
9191
<build>
9292
<pluginManagement>
9393
<plugins>
94+
<plugin>
95+
<groupId>org.apache.maven.plugins</groupId>
96+
<artifactId>maven-clean-plugin</artifactId>
97+
<version>3.2.0</version>
98+
</plugin>
99+
<plugin>
100+
<groupId>org.apache.maven.plugins</groupId>
101+
<artifactId>maven-resources-plugin</artifactId>
102+
<version>3.3.0</version>
103+
</plugin>
94104
<plugin>
95105
<groupId>org.apache.maven.plugins</groupId>
96106
<artifactId>maven-compiler-plugin</artifactId>
97107
<version>3.10.1</version>
98108
</plugin>
109+
<plugin>
110+
<groupId>org.apache.maven.plugins</groupId>
111+
<artifactId>maven-install-plugin</artifactId>
112+
<version>3.1.0</version>
113+
</plugin>
114+
<plugin>
115+
<groupId>org.apache.maven.plugins</groupId>
116+
<artifactId>maven-deploy-plugin</artifactId>
117+
<version>3.1.0</version>
118+
</plugin>
99119
<plugin>
100120
<groupId>org.apache.maven.plugins</groupId>
101121
<artifactId>maven-source-plugin</artifactId>
102122
<version>3.2.1</version>
103-
<executions>
104-
<execution>
105-
<goals>
106-
<goal>jar</goal>
107-
</goals>
108-
</execution>
109-
</executions>
110123
</plugin>
111124
<plugin>
112125
<groupId>org.apache.maven.plugins</groupId>
@@ -116,14 +129,6 @@
116129
<additionalOptions>--allow-script-in-comments</additionalOptions>
117130
<failOnError>false</failOnError>
118131
</configuration>
119-
<executions>
120-
<execution>
121-
<id>attach-javadocs</id>
122-
<goals>
123-
<goal>jar</goal>
124-
</goals>
125-
</execution>
126-
</executions>
127132
</plugin>
128133
<plugin>
129134
<groupId>org.apache.maven.plugins</groupId>
@@ -153,7 +158,7 @@
153158
<plugin>
154159
<groupId>org.apache.maven.plugins</groupId>
155160
<artifactId>maven-jar-plugin</artifactId>
156-
<version>3.2.0</version>
161+
<version>3.3.0</version>
157162
<configuration>
158163
<archive>
159164
<manifest>
@@ -164,6 +169,30 @@
164169
</plugin>
165170
</plugins>
166171
</pluginManagement>
172+
<plugins>
173+
<plugin>
174+
<groupId>org.apache.maven.plugins</groupId>
175+
<artifactId>maven-source-plugin</artifactId>
176+
<executions>
177+
<execution>
178+
<goals>
179+
<goal>jar-no-fork</goal>
180+
</goals>
181+
</execution>
182+
</executions>
183+
</plugin>
184+
<plugin>
185+
<groupId>org.apache.maven.plugins</groupId>
186+
<artifactId>maven-javadoc-plugin</artifactId>
187+
<executions>
188+
<execution>
189+
<goals>
190+
<goal>jar</goal>
191+
</goals>
192+
</execution>
193+
</executions>
194+
</plugin>
195+
</plugins>
167196
</build>
168197

169198
<profiles>

0 commit comments

Comments
 (0)