comment

yury-s · yury-s · commit 6d936432f925 · 2025-06-20T16:18:24.000-07:00
diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/APIRequestImpl.java b/playwright/src/main/java/com/microsoft/playwright/impl/APIRequestImpl.java
@@ -66,6 +66,7 @@ public APIRequestContextImpl newContext(NewContextOptions options) {
       params.add("storageState", storageState);
     }
     addToProtocol(params, clientCertificateList);
+    // Timeout here is not the command's timeout, but we pass it for consistency.
     JsonObject result = playwright.sendMessage("newRequest", params, options.timeout).getAsJsonObject();
     APIRequestContextImpl context = playwright.connection.getExistingObject(result.getAsJsonObject("request").get("guid").getAsString());
     context.timeoutSettings.setDefaultTimeout(options.timeout);

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,7 @@ public APIRequestContextImpl newContext(NewContextOptions options) {`
`66`	`66`	`params.add("storageState", storageState);`
`67`	`67`	`}`
`68`	`68`	`addToProtocol(params, clientCertificateList);`
	`69`	`+ // Timeout here is not the command's timeout, but we pass it for consistency.`
`69`	`70`	`JsonObject result = playwright.sendMessage("newRequest", params, options.timeout).getAsJsonObject();`
`70`	`71`	`APIRequestContextImpl context = playwright.connection.getExistingObject(result.getAsJsonObject("request").get("guid").getAsString());`
`71`	`72`	`context.timeoutSettings.setDefaultTimeout(options.timeout);`