test: cleanup test run warnings

Author: mxschmitt

driver-bundle/src/main/java/com/microsoft/playwright/impl/driver/jar/DriverJar.java

@@ -87,8 +87,10 @@ private void installBrowsers(Map<String, String> env) throws IOException, Interr
     }
     ProcessBuilder pb = createProcessBuilder();
     pb.command().add("install");
-    pb.redirectError(ProcessBuilder.Redirect.INHERIT);
-    pb.redirectOutput(ProcessBuilder.Redirect.INHERIT);
+    if (System.getenv("PW_JAVA_INTERNAL_SILENT_INSTALL") != null) {
+      pb.redirectError(ProcessBuilder.Redirect.INHERIT);
+      pb.redirectOutput(ProcessBuilder.Redirect.INHERIT);
+    }
     Process p = pb.start();
     boolean result = p.waitFor(10, TimeUnit.MINUTES);
     if (!result) {

driver-bundle/src/test/java/com/microsoft/playwright/impl/driver/jar/TestInstall.java

@@ -74,6 +74,7 @@ void shouldThrowWhenBrowserPathIsInvalid(@TempDir Path tmpDir) throws NoSuchFiel
     // Make sure the browsers are not installed yet by pointing at an empty dir.
     env.put("PLAYWRIGHT_BROWSERS_PATH", tmpDir.toString());
     env.put("PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD", "false");
+    env.put("PW_JAVA_INTERNAL_SILENT_INSTALL", "true");
 
     RuntimeException exception = assertThrows(RuntimeException.class, () -> Driver.createAndInstall(env, true));
     String message = exception.getMessage();

playwright/pom.xml

@@ -57,6 +57,10 @@
       <groupId>org.java-websocket</groupId>
       <artifactId>Java-WebSocket</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>
+    </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter-engine</artifactId>

playwright/src/test/java/com/microsoft/playwright/Server.java

@@ -218,7 +218,7 @@ public void handle(HttpExchange exchange) throws IOException {
     }
     long contentLength = body.size();
     // -1 means no body, 0 means chunked encoding.
-    exchange.sendResponseHeaders(200, contentLength == 0 ? -1 : contentLength);
+    exchange.sendResponseHeaders(200, (contentLength == 0 || exchange.getRequestMethod().equals("HEAD")) ? -1 : contentLength);
     if (contentLength > 0) {
       exchange.getResponseBody().write(body.toByteArray());
     }

playwright/src/test/java/com/microsoft/playwright/TestBrowserContextCredentials.java

@@ -33,7 +33,6 @@ static boolean isChromiumHeadedLike() {
   @Test
   @DisabledIf(value="isChromiumHeadedLike", disabledReason="fail")
   void shouldFailWithoutCredentials() {
-    System.out.println("channel2 " + getBrowserChannelFromEnv());
     server.setAuth("/empty.html", "user", "pass");
     Response response = page.navigate(server.EMPTY_PAGE);
     assertEquals(401, response.status());

playwright/src/test/java/com/microsoft/playwright/TestGlobalFetch.java

@@ -337,7 +337,7 @@ void shouldReturnBodyForFailingRequests() {
     for (String method : new String[] {"head", "put", "trace"}) {
       server.setRoute("/empty.html", exchange -> {
         exchange.getResponseHeaders().set("Content-type", "text/plain");
-        exchange.sendResponseHeaders(404, 10);
+        exchange.sendResponseHeaders(404, exchange.getRequestMethod().equals("HEAD") ? -1 : 10);
         try (Writer writer = new OutputStreamWriter(exchange.getResponseBody())) {
           writer.write("Not found.");
         }

pom.xml

@@ -48,6 +48,7 @@
     <junit.version>5.12.0</junit.version>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <websocket.version>1.6.0</websocket.version>
+    <slf4j.version>2.0.17</slf4j.version>
     <opentest4j.version>1.3.0</opentest4j.version>
   </properties>
 
@@ -91,6 +92,12 @@
         <version>${websocket.version}</version>
         <scope>test</scope>
       </dependency>
+      <dependency>
+        <groupId>org.slf4j</groupId>
+        <artifactId>slf4j-simple</artifactId>
+        <version>${slf4j.version}</version>
+        <scope>test</scope>
+      </dependency>
       <dependency>
         <groupId>org.junit.jupiter</groupId>
         <artifactId>junit-jupiter-api</artifactId>