fix: page.pause should not throw (#1204)

yury-s · web-flow · commit 8dfb745da9ae · 2023-02-16T11:21:24.000-08:00
diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java b/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java
@@ -949,8 +949,8 @@ public PageImpl opener() {
 
   @Override
   public void pause() {
-    withLogging("BrowserContext.pause", () -> {
-      new WaitableRace<>(asList(context().pause(), (Waitable<JsonElement>) waitableClosedOrCrashed)).get();
+    withLogging("Page.pause", () -> {
+      runUntil(() -> {}, new WaitableRace<>(asList(context().pause(), (Waitable<JsonElement>) waitableClosedOrCrashed)));
     });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -949,8 +949,8 @@ public PageImpl opener() {`
`949`	`949`
`950`	`950`	`@Override`
`951`	`951`	`public void pause() {`
`952`		`- withLogging("BrowserContext.pause", () -> {`
`953`		`- new WaitableRace<>(asList(context().pause(), (Waitable<JsonElement>) waitableClosedOrCrashed)).get();`
	`952`	`+ withLogging("Page.pause", () -> {`
	`953`	`+ runUntil(() -> {}, new WaitableRace<>(asList(context().pause(), (Waitable<JsonElement>) waitableClosedOrCrashed)));`
`954`	`954`	`});`
`955`	`955`	`}`
`956`	`956`