read baseUrl and videoDir from initializer

Author: Skn0tt

playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java

@@ -102,7 +102,20 @@ enum EventType {
     request = connection.getExistingObject(initializer.getAsJsonObject("requestContext").get("guid").getAsString());
     request.timeoutSettings = timeoutSettings;
     clock = new ClockImpl(this);
-    closePromise = new WaitableEvent<>(listeners, EventType.CLOSE);
+    closePromise = new WaitableEvent<>(listeners, EventType.CLOSE); 
+
+    String url = initializer.getAsJsonObject("options").get("baseUrl").getAsString();
+    if (url != null) {
+      try {
+        this.baseUrl = new URL(url);
+      } catch (MalformedURLException e) {
+      }
+    }
+  
+    JsonObject recordVideo = initializer.getAsJsonObject("options").getAsJsonObject("recordVideo");
+    if (recordVideo != null) {
+      this.videosDir = Path.of(recordVideo.get("dir").getAsString());
+    }
   }
 
   void setRecordHar(Path path, HarContentPolicy policy) {
@@ -111,14 +124,6 @@ void setRecordHar(Path path, HarContentPolicy policy) {
     }
   }
 
-  void setBaseUrl(String spec) {
-    try {
-      this.baseUrl = new URL(spec);
-    } catch (MalformedURLException e) {
-      this.baseUrl = null;
-    }
-  }
-
   String effectiveCloseReason() {
     if (closeReason != null) {
       return closeReason;

playwright/src/main/java/com/microsoft/playwright/impl/BrowserImpl.java

@@ -181,10 +181,6 @@ private BrowserContextImpl newContextImpl(NewContextOptions options) {
     params.addProperty("testIdAttributeName", browserType.playwright.sharedSelectors.testIdAttributeName);
     JsonElement result = sendMessage("newContext", params);
     BrowserContextImpl context = connection.getExistingObject(result.getAsJsonObject().getAsJsonObject("context").get("guid").getAsString());
-    context.videosDir = options.recordVideoDir;
-    if (options.baseURL != null) {
-      context.setBaseUrl(options.baseURL);
-    }
     context.initializeHarFromOptions(harOptions);
     return context;
   }

playwright/src/main/java/com/microsoft/playwright/impl/BrowserTypeImpl.java

@@ -207,10 +207,6 @@ private BrowserContextImpl launchPersistentContextImpl(Path userDataDir, LaunchP
     BrowserImpl browser = connection.getExistingObject(json.getAsJsonObject("browser").get("guid").getAsString());
     browser.connectToBrowserType(this, options.tracesDir);
     BrowserContextImpl context = connection.getExistingObject(json.getAsJsonObject("context").get("guid").getAsString());
-    context.videosDir = options.recordVideoDir;
-    if (options.baseURL != null) {
-      context.setBaseUrl(options.baseURL);
-    }
     context.initializeHarFromOptions(harOptions);
     context.tracing().setTracesDir(options.tracesDir);
     return context;