Skip to content

Commit 90aa457

Browse files
authored
chore: move junit impl to com.microsoft.playwright.impl.junit (#1538)
1 parent 1a8f5f7 commit 90aa457

File tree

12 files changed

+18
-22
lines changed

12 files changed

+18
-22
lines changed

playwright/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<artifactId>maven-javadoc-plugin</artifactId>
2727
<configuration combine.self="append">
2828
<subpackages>com.microsoft.playwright</subpackages>
29-
<excludePackageNames>com.microsoft.playwright.impl,com.microsoft.playwright.junit.impl</excludePackageNames>
29+
<excludePackageNames>com.microsoft.playwright.impl</excludePackageNames>
3030
</configuration>
3131
</plugin>
3232
<plugin>

playwright/src/main/java/com/microsoft/playwright/impl/APIRequestContextImpl.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.microsoft.playwright.impl;
1818

1919
import com.google.gson.*;
20-
import com.google.gson.stream.JsonReader;
2120
import com.microsoft.playwright.APIRequestContext;
2221
import com.microsoft.playwright.APIResponse;
2322
import com.microsoft.playwright.PlaywrightException;
@@ -26,7 +25,6 @@
2625
import com.microsoft.playwright.options.RequestOptions;
2726

2827
import java.io.File;
29-
import java.io.StringReader;
3028
import java.nio.charset.StandardCharsets;
3129
import java.nio.file.Path;
3230
import java.util.Base64;

playwright/src/main/java/com/microsoft/playwright/junit/impl/APIRequestContextExtension.java renamed to playwright/src/main/java/com/microsoft/playwright/impl/junit/APIRequestContextExtension.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.microsoft.playwright.junit.impl;
17+
package com.microsoft.playwright.impl.junit;
1818

1919
import com.microsoft.playwright.APIRequest;
2020
import com.microsoft.playwright.APIRequestContext;
@@ -23,7 +23,7 @@
2323
import com.microsoft.playwright.junit.Options;
2424
import org.junit.jupiter.api.extension.*;
2525

26-
import static com.microsoft.playwright.junit.impl.ExtensionUtils.isParameterSupported;
26+
import static com.microsoft.playwright.impl.junit.ExtensionUtils.isParameterSupported;
2727

2828
public class APIRequestContextExtension implements ParameterResolver, BeforeEachCallback, AfterAllCallback {
2929
private static final ThreadLocal<APIRequestContext> threadLocalAPIRequestContext = new ThreadLocal<>();

playwright/src/main/java/com/microsoft/playwright/junit/impl/BrowserContextExtension.java renamed to playwright/src/main/java/com/microsoft/playwright/impl/junit/BrowserContextExtension.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.microsoft.playwright.junit.impl;
17+
package com.microsoft.playwright.impl.junit;
1818

1919
import com.microsoft.playwright.Browser;
2020
import com.microsoft.playwright.BrowserContext;
@@ -24,7 +24,7 @@
2424
import com.microsoft.playwright.junit.Options;
2525
import org.junit.jupiter.api.extension.*;
2626

27-
import static com.microsoft.playwright.junit.impl.ExtensionUtils.*;
27+
import static com.microsoft.playwright.impl.junit.ExtensionUtils.*;
2828

2929
public class BrowserContextExtension implements ParameterResolver, AfterEachCallback {
3030
private static final ThreadLocal<BrowserContext> threadLocalBrowserContext = new ThreadLocal<>();

playwright/src/main/java/com/microsoft/playwright/junit/impl/BrowserExtension.java renamed to playwright/src/main/java/com/microsoft/playwright/impl/junit/BrowserExtension.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.microsoft.playwright.junit.impl;
17+
package com.microsoft.playwright.impl.junit;
1818

1919
import com.microsoft.playwright.Browser;
2020
import com.microsoft.playwright.BrowserType;
@@ -24,7 +24,8 @@
2424
import com.microsoft.playwright.junit.Options;
2525
import org.junit.jupiter.api.extension.*;
2626

27-
import static com.microsoft.playwright.junit.impl.ExtensionUtils.isParameterSupported;
27+
import static com.microsoft.playwright.impl.junit.ExtensionUtils.*;
28+
2829
public class BrowserExtension implements ParameterResolver, AfterAllCallback {
2930
private static final ThreadLocal<Browser> threadLocalBrowser = new ThreadLocal<>();
3031

playwright/src/main/java/com/microsoft/playwright/junit/impl/DefaultOptions.java renamed to playwright/src/main/java/com/microsoft/playwright/impl/junit/DefaultOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.microsoft.playwright.junit.impl;
17+
package com.microsoft.playwright.impl.junit;
1818

1919
import com.microsoft.playwright.junit.Options;
2020
import com.microsoft.playwright.junit.OptionsFactory;

playwright/src/main/java/com/microsoft/playwright/junit/impl/DeviceDescriptor.java renamed to playwright/src/main/java/com/microsoft/playwright/impl/junit/DeviceDescriptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.microsoft.playwright.junit.impl;
17+
package com.microsoft.playwright.impl.junit;
1818

1919
import com.google.gson.Gson;
2020
import com.google.gson.JsonArray;

playwright/src/main/java/com/microsoft/playwright/junit/impl/ExtensionUtils.java renamed to playwright/src/main/java/com/microsoft/playwright/impl/junit/ExtensionUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.microsoft.playwright.junit.impl;
17+
package com.microsoft.playwright.impl.junit;
1818

1919
import com.microsoft.playwright.Playwright;
2020
import com.microsoft.playwright.junit.Options;

playwright/src/main/java/com/microsoft/playwright/junit/impl/OptionsExtension.java renamed to playwright/src/main/java/com/microsoft/playwright/impl/junit/OptionsExtension.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,15 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.microsoft.playwright.junit.impl;
17+
package com.microsoft.playwright.impl.junit;
1818

1919
import com.microsoft.playwright.PlaywrightException;
2020
import com.microsoft.playwright.junit.Options;
21-
import com.microsoft.playwright.junit.OptionsFactory;
2221
import com.microsoft.playwright.junit.UsePlaywright;
2322
import org.junit.jupiter.api.extension.AfterAllCallback;
2423
import org.junit.jupiter.api.extension.ExtensionContext;
2524

26-
import static com.microsoft.playwright.junit.impl.ExtensionUtils.getUsePlaywrightAnnotation;
25+
import static com.microsoft.playwright.impl.junit.ExtensionUtils.*;
2726

2827
public class OptionsExtension implements AfterAllCallback {
2928
private static final ThreadLocal<Options> threadLocalOptions = new ThreadLocal<>();

playwright/src/main/java/com/microsoft/playwright/junit/impl/PageExtension.java renamed to playwright/src/main/java/com/microsoft/playwright/impl/junit/PageExtension.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,13 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.microsoft.playwright.junit.impl;
17+
package com.microsoft.playwright.impl.junit;
1818

1919
import com.microsoft.playwright.BrowserContext;
2020
import com.microsoft.playwright.Page;
2121
import org.junit.jupiter.api.extension.*;
2222

23-
import static com.microsoft.playwright.junit.impl.ExtensionUtils.isClassHook;
24-
import static com.microsoft.playwright.junit.impl.ExtensionUtils.isParameterSupported;
23+
import static com.microsoft.playwright.impl.junit.ExtensionUtils.*;
2524

2625
public class PageExtension implements ParameterResolver, AfterEachCallback {
2726
private static final ThreadLocal<Page> threadLocalPage = new ThreadLocal<>();

0 commit comments

Comments
 (0)