Skip to content

Commit a2ba1f6

Browse files
committed
fix errors
1 parent 1f07b32 commit a2ba1f6

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
- name: Build & Install
3232
run: mvn -B install -D skipTests --no-transfer-progress
3333
- name: Install browsers
34-
run: mvn compile exec:java -f playwright -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps"
34+
run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps" -f playwright/pom.xml
3535
- name: Run tests
3636
run: mvn test --no-transfer-progress --fail-at-end -D org.slf4j.simpleLogger.showDateTime=true -D org.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss
3737
env:
@@ -81,7 +81,7 @@ jobs:
8181
- name: Build & Install
8282
run: mvn -B install -D skipTests --no-transfer-progress
8383
- name: Install browsers
84-
run: mvn compile exec:java -f playwright/pom.xml -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps"
84+
run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps" -f playwright/pom.xml
8585
- name: Install MS Edge
8686
if: matrix.browser-channel == 'msedge' && matrix.os == 'macos-latest'
8787
shell: bash
@@ -112,6 +112,8 @@ jobs:
112112
run: scripts/download_driver.sh
113113
- name: Build & Install
114114
run: mvn -B install -D skipTests --no-transfer-progress
115+
- name: Install browsers
116+
run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps" -f playwright/pom.xml
115117
- name: Run tests
116118
run: mvn test --no-transfer-progress --fail-at-end
117119
env:

.github/workflows/verify_api.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Regenerate APIs
2727
run: scripts/generate_api.sh
2828
- name: Install browsers
29-
run: mvn compile exec:java -f playwright/pom.xml -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps"
29+
run: mvn compile exec:java --no-transfer-progress -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps" -f playwright/pom.xml
3030
- name: Update browser versions in README
3131
run: scripts/update_readme.sh
3232
- name: Verify API is up to date

playwright/src/main/java/com/microsoft/playwright/impl/LocatorAssertionsImpl.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,9 @@ public void hasValues(Pattern[] patterns, HasValuesOptions options) {
328328

329329
@Override
330330
public void matchesAriaSnapshot(String expected, MatchesAriaSnapshotOptions snapshotOptions) {
331+
if (snapshotOptions == null) {
332+
snapshotOptions = new MatchesAriaSnapshotOptions();
333+
}
331334
FrameExpectOptions options = convertType(snapshotOptions, FrameExpectOptions.class);
332335
options.expectedValue = serializeArgument(expected);
333336
expectImpl("to.match.aria", options, expected,"Locator expected to match Aria snapshot");

0 commit comments

Comments
 (0)