Skip to content

Commit a8afd68

Browse files
committed
roll to 1.53.0
1 parent 442bb41 commit a8afd68

File tree

7 files changed

+4
-15
lines changed

7 files changed

+4
-15
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Playwright is a Java library to automate [Chromium](https://www.chromium.org/Hom
1010

1111
| | Linux | macOS | Windows |
1212
| :--- | :---: | :---: | :---: |
13-
| Chromium <!-- GEN:chromium-version -->138.0.7204.4<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
13+
| Chromium <!-- GEN:chromium-version -->138.0.7204.15<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
1414
| WebKit <!-- GEN:webkit-version -->18.5<!-- GEN:stop --> ||||
1515
| Firefox <!-- GEN:firefox-version -->139.0<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
1616

playwright/src/main/java/com/microsoft/playwright/impl/SharedSelectors.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,13 @@ private void registerImpl(String name, String script, RegisterOptions options) {
7272
JsonObject engine = new JsonObject();
7373
engine.addProperty("name", name);
7474
engine.addProperty("source", script);
75-
if (options.contentScript != null) {
75+
if (options != null && options.contentScript != null) {
7676
engine.addProperty("contentScript", options.contentScript);
7777
}
7878
for (BrowserContextImpl context : contextsForSelectors) {
7979
JsonObject params = new JsonObject();
8080
params.add("selectorEngine", engine);
81-
context.sendMessageAsync("registerSelectorEngine", params);
81+
context.sendMessage("registerSelectorEngine", params);
8282
}
8383
selectorEngines.add(engine);
8484
}

playwright/src/test/java/com/microsoft/playwright/TestBrowserTypeConnect.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import org.junit.jupiter.api.AfterAll;
2121
import org.junit.jupiter.api.Assumptions;
2222
import org.junit.jupiter.api.BeforeAll;
23-
import org.junit.jupiter.api.Disabled;
2423
import org.junit.jupiter.api.Test;
2524
import org.junit.jupiter.api.io.TempDir;
2625

@@ -297,7 +296,6 @@ void shouldEmitCloseEventsOnPagesAndContexts() throws InterruptedException {
297296
assertEquals(Arrays.asList("page", "context"), events);
298297
}
299298

300-
@Disabled("Temporarily skipping until the roll that contains https://github.com/microsoft/playwright/pull/36227")
301299
@Test
302300
void shouldRespectSelectors() {
303301
String mycss = "{\n" +

playwright/src/test/java/com/microsoft/playwright/TestDefaultBrowserContext2.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import com.microsoft.playwright.options.Geolocation;
2121
import org.junit.jupiter.api.AfterEach;
2222
import org.junit.jupiter.api.Assumptions;
23-
import org.junit.jupiter.api.Disabled;
2423
import org.junit.jupiter.api.Test;
2524
import org.junit.jupiter.api.condition.DisabledIf;
2625
import org.junit.jupiter.api.io.TempDir;
@@ -227,7 +226,6 @@ void coverageShouldBeMissing() {
227226
// TODO:
228227
}
229228

230-
@Disabled("Temporarily skipping until the roll that contains https://github.com/microsoft/playwright/pull/36227")
231229
@Test
232230
void shouldRespectSelectors() {
233231
Page page = launchPersistent();

playwright/src/test/java/com/microsoft/playwright/TestElementHandleConvenience.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.microsoft.playwright;
1818

19-
import org.junit.jupiter.api.Disabled;
2019
import org.junit.jupiter.api.Test;
2120

2221
import java.util.Collections;
@@ -113,7 +112,6 @@ void textContentShouldWork() {
113112
assertEquals("Text,\nmore text", page.textContent("#inner"));
114113
}
115114

116-
@Disabled("Temporarily skipping until the roll that contains https://github.com/microsoft/playwright/pull/36227")
117115
@Test
118116
void textContentShouldBeAtomic() {
119117
String createDummySelector = "{\n" +
@@ -137,7 +135,6 @@ void textContentShouldBeAtomic() {
137135
assertEquals("modified", page.evaluate("() => document.querySelector('div').textContent"));
138136
}
139137

140-
@Disabled("Temporarily skipping until the roll that contains https://github.com/microsoft/playwright/pull/36227")
141138
@Test
142139
void innerTextShouldBeAtomic() {
143140
String createDummySelector = "{\n" +
@@ -161,7 +158,6 @@ void innerTextShouldBeAtomic() {
161158
assertEquals("modified", page.evaluate("() => document.querySelector('div').innerText"));
162159
}
163160

164-
@Disabled("Temporarily skipping until the roll that contains https://github.com/microsoft/playwright/pull/36227")
165161
@Test
166162
void innerHTMLShouldBeAtomic() {
167163
String createDummySelector = "{\n" +
@@ -185,7 +181,6 @@ void innerHTMLShouldBeAtomic() {
185181
assertEquals("modified", page.evaluate("() => document.querySelector('div').innerHTML"));
186182
}
187183

188-
@Disabled("Temporarily skipping until the roll that contains https://github.com/microsoft/playwright/pull/36227")
189184
@Test
190185
void getAttributeShouldBeAtomic() {
191186
String createDummySelector = "{\n" +

playwright/src/test/java/com/microsoft/playwright/TestSelectorsRegister.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,12 @@
1616

1717
package com.microsoft.playwright;
1818

19-
import org.junit.jupiter.api.Disabled;
2019
import org.junit.jupiter.api.Test;
2120

2221
import java.nio.file.Paths;
2322

2423
import static org.junit.jupiter.api.Assertions.*;
2524

26-
@Disabled("Temporarily skipping until the roll that contains https://github.com/microsoft/playwright/pull/36227")
2725
public class TestSelectorsRegister extends TestBase {
2826
@Test
2927
void shouldWork() {

scripts/DRIVER_VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.53.0-beta-1749131401000
1+
1.53.0

0 commit comments

Comments
 (0)