Skip to content

Commit b59d88c

Browse files
committed
remove markAsInternalType
1 parent 393a9c0 commit b59d88c

File tree

7 files changed

+0
-14
lines changed

7 files changed

+0
-14
lines changed

playwright/src/main/java/com/microsoft/playwright/impl/ChannelOwner.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ class ChannelOwner extends LoggingSupport {
3535
final String guid;
3636
final JsonObject initializer;
3737
private boolean wasCollected;
38-
private boolean isInternalType;
3938

4039
protected ChannelOwner(ChannelOwner parent, String type, String guid, JsonObject initializer) {
4140
this(parent.connection, parent, type, guid, initializer);
@@ -59,10 +58,6 @@ private ChannelOwner(Connection connection, ChannelOwner parent, String type, St
5958
}
6059
}
6160

62-
void markAsInternalType() {
63-
isInternalType = true;
64-
}
65-
6661
void disposeChannelOwner(boolean wasGarbageCollected) {
6762
// Clean up from parent and connection.
6863
if (parent != null) {
@@ -89,9 +84,6 @@ <T> T withWaitLogging(String apiName, Function<Logger, T> code) {
8984

9085
@Override
9186
<T> T withLogging(String apiName, Supplier<T> code) {
92-
if (isInternalType) {
93-
apiName = null;
94-
}
9587
String previousApiName = connection.setApiName(apiName);
9688
try {
9789
return super.withLogging(apiName, code);

playwright/src/main/java/com/microsoft/playwright/impl/LocalUtils.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
public class LocalUtils extends ChannelOwner {
2929
LocalUtils(ChannelOwner parent, String type, String guid, JsonObject initializer) {
3030
super(parent, type, guid, initializer);
31-
markAsInternalType();
3231
}
3332

3433
JsonArray deviceDescriptors() {

playwright/src/main/java/com/microsoft/playwright/impl/RequestImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ static class FallbackOverrides {
5353

5454
RequestImpl(ChannelOwner parent, String type, String guid, JsonObject initializer) {
5555
super(parent, type, guid, initializer);
56-
markAsInternalType();
5756

5857
if (initializer.has("redirectedFrom")) {
5958
redirectedFrom = connection.getExistingObject(initializer.getAsJsonObject("redirectedFrom").get("guid").getAsString());

playwright/src/main/java/com/microsoft/playwright/impl/ResponseImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ public class ResponseImpl extends ChannelOwner implements Response {
4040

4141
ResponseImpl(ChannelOwner parent, String type, String guid, JsonObject initializer) {
4242
super(parent, type, guid, initializer);
43-
markAsInternalType();
4443
headers = new RawHeaders(asList(gson().fromJson(initializer.getAsJsonArray("headers"), HttpHeader[].class)));
4544
request = connection.getExistingObject(initializer.getAsJsonObject("request").get("guid").getAsString());
4645
request.timing = gson().fromJson(initializer.get("timing"), Timing.class);

playwright/src/main/java/com/microsoft/playwright/impl/RouteImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public class RouteImpl extends ChannelOwner implements Route {
3838

3939
public RouteImpl(ChannelOwner parent, String type, String guid, JsonObject initializer) {
4040
super(parent, type, guid, initializer);
41-
markAsInternalType();
4241
request = connection.getExistingObject(initializer.getAsJsonObject("request").get("guid").getAsString());
4342
}
4443

playwright/src/main/java/com/microsoft/playwright/impl/TracingImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ class TracingImpl extends ChannelOwner implements Tracing {
3333

3434
TracingImpl(ChannelOwner parent, String type, String guid, JsonObject initializer) {
3535
super(parent, type, guid, initializer);
36-
markAsInternalType();
3736
}
3837

3938
private void stopChunkImpl(Path path) {

playwright/src/main/java/com/microsoft/playwright/impl/WebSocketRouteImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ public String url() {
6969

7070
WebSocketRouteImpl(ChannelOwner parent, String type, String guid, JsonObject initializer) {
7171
super(parent, type, guid, initializer);
72-
markAsInternalType();
7372
}
7473

7574
@Override

0 commit comments

Comments
 (0)