Skip to content

Commit c237fae

Browse files
authored
feat: bundle arm64 node binary for Apple Silicon (#1255)
1 parent 1783b11 commit c237fae

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

driver-bundle/src/main/java/com/microsoft/playwright/impl/driver/jar/DriverJar.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,11 @@ private static String platformDir() {
194194
}
195195
}
196196
if (name.contains("mac os x")) {
197-
return "mac";
197+
if (arch.equals("aarch64")) {
198+
return "mac-arm64";
199+
} else {
200+
return "mac";
201+
}
198202
}
199203
throw new RuntimeException("Unexpected os.name value: " + name);
200204
}

scripts/download_driver_for_all_platforms.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ fi
3333
mkdir -p driver
3434
cd driver
3535

36-
for PLATFORM in mac linux linux-arm64 win32_x64
36+
for PLATFORM in mac mac-arm64 linux linux-arm64 win32_x64
3737
do
3838
FILE_NAME=$FILE_PREFIX-$PLATFORM.zip
3939
if [[ -d $PLATFORM ]]; then

0 commit comments

Comments
 (0)