more

Author: Skn0tt

playwright/src/main/java/com/microsoft/playwright/impl/Connection.java

@@ -150,9 +150,11 @@ private WaitableResult<JsonElement> internalSendMessage(String guid, String meth
     if (titleReported) {
       metadata.addProperty("internal", true);
     } else {
-      metadata.addProperty("title", title);
-      // All but first message in a custom-titled API call are considered internal and will be hidden from the inspector.
-      titleReported = true;
+      if (title != null) {
+        metadata.addProperty("title", title);
+        // All but first message in a custom-titled API call are considered internal and will be hidden from the inspector.
+        titleReported = true;
+      }
       if (stackTraceCollector != null) {
         stack = stackTraceCollector.currentStackTrace();
         if (!stack.isEmpty()) {

playwright/src/test/java/com/microsoft/playwright/TestPageAriaSnapshot.java

@@ -1,6 +1,5 @@
 package com.microsoft.playwright;
 
-import com.microsoft.playwright.Locator.AriaSnapshotOptions;
 import com.microsoft.playwright.junit.FixtureTest;
 import com.microsoft.playwright.junit.UsePlaywright;
 import org.junit.jupiter.api.Test;
@@ -13,8 +12,6 @@
 
 import static com.microsoft.playwright.assertions.PlaywrightAssertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 
 @FixtureTest
 @UsePlaywright

playwright/src/test/java/com/microsoft/playwright/TestPdf.java

@@ -60,13 +60,6 @@ void shouldBeAbleToGenerateOutline(@TempDir Path tempDir) throws IOException {
     assertTrue(outlineSize > noOutlineSize, "Unexpected sizes: " + outlineSize + " noOutline: " + noOutlineSize);
   }
 
-  @Test
-  @DisabledIf(value="com.microsoft.playwright.TestBase#isChromium", disabledReason="skip")
-  void shouldThrowInNonChromium() {
-    PlaywrightException e = assertThrows(PlaywrightException.class, () -> page.pdf());
-    assertTrue(e.getMessage().contains("PDF generation is only supported for Headless Chromium"), e.getMessage());
-  }
-
 
   @Test
   @DisabledIf(value="com.microsoft.playwright.TestBase#isChromium", disabledReason="skip")

playwright/src/test/java/com/microsoft/playwright/TestTracing.java

@@ -17,6 +17,7 @@
 package com.microsoft.playwright;
 
 import com.google.gson.Gson;
+import com.google.gson.annotations.SerializedName;
 import com.microsoft.playwright.options.AriaRole;
 import com.microsoft.playwright.options.Location;
 import com.microsoft.playwright.options.MouseButton;
@@ -202,8 +203,8 @@ void traceGroupGroupEnd(@TempDir Path tempDir) throws Exception {
     context.tracing().stop(new Tracing.StopOptions().setPath(traceFile1));
 
     List<TraceEvent> events = parseTraceEvents(traceFile1);
-    List<String> calls = events.stream().filter(e -> e.title != null).map(e -> e.title).collect(Collectors.toList());
-    assertEquals(asList("outer group", "Page.navigate", "inner group 1", "Frame.click", "inner group 2", "Page.isVisible"), calls);
+    List<String> calls = events.stream().filter(e -> e.renderedTitle() != null).map(e -> e.renderedTitle()).collect(Collectors.toList());
+    assertEquals(asList("outer group", "Frame.goto", "inner group 1", "Frame.click", "inner group 2", "Frame.isVisible"), calls);
   }
 
   @Test
@@ -240,30 +241,30 @@ void shouldTraceVariousAPIs(@TempDir Path tempDir) throws Exception {
     context.tracing().stop(new Tracing.StopOptions().setPath(traceFile1));
 
     List<TraceEvent> events = parseTraceEvents(traceFile1);
-    List<String> calls = events.stream().filter(e -> e.title != null).map(e -> e.title)
+    List<String> calls = events.stream().filter(e -> e.renderedTitle() != null).map(e -> e.renderedTitle())
         .collect(Collectors.toList());
     assertEquals(asList(
-        "Clock.install",
-        "Page.setContent",
+        "BrowserContext.clockInstall",
+        "Frame.setContent",
         "Frame.click",
         "Frame.click",
-        "Keyboard.type",
-        "Keyboard.press",
-        "Keyboard.down",
-        "Keyboard.insertText",
-        "Keyboard.up",
-        "Mouse.move",
-        "Mouse.down",
-        "Mouse.move",
-        "Mouse.wheel",
-        "Mouse.up",
-        "Clock.fastForward",
-        "Clock.fastForward",
-        "Clock.pauseAt",
-        "Clock.runFor",
-        "Clock.setFixedTime",
-        "Clock.setSystemTime",
-        "Clock.resume",
+        "Page.keyboardType",
+        "Page.keyboardPress",
+        "Page.keyboardDown",
+        "Page.keyboardInsertText",
+        "Page.keyboardUp",
+        "Page.mouseMove",
+        "Page.mouseDown",
+        "Page.mouseMove",
+        "Page.mouseWheel",
+        "Page.mouseUp",
+        "BrowserContext.clockFastForward",
+        "BrowserContext.clockFastForward",
+        "BrowserContext.clockPauseAt",
+        "BrowserContext.clockRunFor",
+        "BrowserContext.clockSetFixedTime",
+        "BrowserContext.clockSetSystemTime",
+        "BrowserContext.clockResume",
         "Frame.click"),
         calls);
   }
@@ -284,20 +285,31 @@ public void shouldNotRecordNetworkActions(@TempDir Path tempDir) throws IOExcept
     context.tracing().stop(new Tracing.StopOptions().setPath(traceFile1));
 
     List<TraceEvent> events = parseTraceEvents(traceFile1);
-    List<String> calls = events.stream().filter(e -> e.title != null).map(e -> e.title)
+    List<String> calls = events.stream().filter(e -> e.renderedTitle() != null).map(e -> e.renderedTitle())
       .collect(Collectors.toList());
-    assertEquals(asList("Page.navigate"), calls);
+    assertEquals(asList("Frame.goto"), calls);
   }
 
   private static class TraceEvent {
     String type;
     String name;
-    String apiName;
     String title;
+    @SerializedName("class")
+    String clazz;
     String method;
     Double startTime;
     Double endTime;
     String callId;
+
+    String renderedTitle() {
+      if (title != null) {
+        return title;
+      }
+      if (clazz != null && method != null) {
+        return clazz + "." + method;
+      }
+      return null;
+    }
   }
 
   private static List<TraceEvent> parseTraceEvents(Path traceFile) throws IOException {