Skip to content

Commit e41c504

Browse files
committed
skip relative dir test on windows
1 parent 9a59c50 commit e41c504

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

playwright/src/test/java/com/microsoft/playwright/TestBrowserContextCookies.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@
3131
import static org.junit.jupiter.api.Assertions.*;
3232

3333
public class TestBrowserContextCookies extends TestBase {
34+
static boolean isWebkitWindows() {
35+
return isWebKit() && isWindows;
36+
}
37+
3438
@Test
3539
void shouldGetACookie() {
3640
page.navigate(server.EMPTY_PAGE);
@@ -96,10 +100,6 @@ void shouldProperlyReportHttpOnlyCookie() {
96100
assertTrue(cookies.get(0).httpOnly);
97101
}
98102

99-
static boolean isWebKitWindows() {
100-
return isWebKit() && getOS() == Utils.OS.WINDOWS;
101-
}
102-
103103
@Test
104104
@DisabledIf(value="isWebKitWindows", disabledReason="fail")
105105
void shouldProperlyReportStrictSameSiteCookie() {
@@ -192,10 +192,6 @@ void shouldGetCookiesFromMultipleUrls() {
192192
"}]", cookies);
193193
}
194194

195-
static boolean isWebkitWindows() {
196-
return isWebKit() && isWindows;
197-
}
198-
199195
@Test
200196
@DisabledIf(value="isWebkitWindows", disabledReason="Same site is not implemented in curl")
201197
void shouldAcceptSameSiteAttribute() {

playwright/src/test/java/com/microsoft/playwright/TestDefaultBrowserContext2.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,12 @@ void shouldSupportContrastOption() {
293293
assertEquals(false, page.evaluate("() => matchMedia('(prefers-contrast: no-preference)').matches"));
294294
}
295295

296+
static boolean tempDirCanBeOnDifferentRoot() {
297+
return isMac;
298+
}
299+
296300
@Test
301+
@DisabledIf(value="tempDirCanBeOnDifferentRoot", disabledReason="IllegalArgument 'other' has different root on GitHub Actions.")
297302
void shouldAcceptRelativeUserDataDir(@TempDir Path tmpDir) throws Exception {
298303
Path userDataDir = tempDir.resolve("user-data-dir");
299304
Path cwd = Paths.get("").toAbsolutePath();

0 commit comments

Comments
 (0)