Skip to content

Commit fb9ae4f

Browse files
committed
Properly mark clock API calls as non-internal, and thus traceable
1 parent 308b991 commit fb9ae4f

File tree

1 file changed

+19
-15
lines changed

1 file changed

+19
-15
lines changed

playwright/src/main/java/com/microsoft/playwright/impl/ClockImpl.java

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,22 @@ class ClockImpl implements Clock {
1212
this.browserContext = browserContext;
1313
}
1414

15+
private void sendMessageWithLogging(String method, JsonObject params) {
16+
browserContext.withLogging("BrowserContext." + method, () -> browserContext.sendMessage(method, params));
17+
}
18+
1519
@Override
1620
public void fastForward(long ticks) {
1721
JsonObject params = new JsonObject();
1822
params.addProperty("ticksNumber", ticks);
19-
browserContext.sendMessage("clockFastForward", params);
23+
sendMessageWithLogging("clockFastForward", params);
2024
}
2125

2226
@Override
2327
public void fastForward(String ticks) {
2428
JsonObject params = new JsonObject();
2529
params.addProperty("ticksString", ticks);
26-
browserContext.sendMessage("clockFastForward", params);
30+
sendMessageWithLogging("clockFastForward", params);
2731
}
2832

2933
@Override
@@ -32,89 +36,89 @@ public void install(InstallOptions options) {
3236
if (options != null) {
3337
parseTime(options.time, params);
3438
}
35-
browserContext.sendMessage("clockInstall", params);
39+
sendMessageWithLogging("clockInstall", params);
3640
}
3741

3842
@Override
3943
public void runFor(long ticks) {
4044
JsonObject params = new JsonObject();
4145
params.addProperty("ticksNumber", ticks);
42-
browserContext.sendMessage("clockRunFor", params);
46+
sendMessageWithLogging("clockRunFor", params);
4347
}
4448

4549
@Override
4650
public void runFor(String ticks) {
4751
JsonObject params = new JsonObject();
4852
params.addProperty("ticksString", ticks);
49-
browserContext.sendMessage("clockRunFor", params);
53+
sendMessageWithLogging("clockRunFor", params);
5054
}
5155

5256
@Override
5357
public void pauseAt(long time) {
5458
JsonObject params = new JsonObject();
5559
params.addProperty("timeNumber", time);
56-
browserContext.sendMessage("clockPauseAt", params);
60+
sendMessageWithLogging("clockPauseAt", params);
5761
}
5862

5963
@Override
6064
public void pauseAt(String time) {
6165
JsonObject params = new JsonObject();
6266
params.addProperty("timeString", time);
63-
browserContext.sendMessage("clockPauseAt", params);
67+
sendMessageWithLogging("clockPauseAt", params);
6468
}
6569

6670
@Override
6771
public void pauseAt(Date time) {
6872
JsonObject params = new JsonObject();
6973
params.addProperty("timeNumber", time.getTime());
70-
browserContext.sendMessage("clockPauseAt", params);
74+
sendMessageWithLogging("clockPauseAt", params);
7175
}
7276

7377
@Override
7478
public void resume() {
75-
browserContext.sendMessage("clockResume");
79+
sendMessageWithLogging("clockResume", new JsonObject());
7680
}
7781

7882
@Override
7983
public void setFixedTime(long time) {
8084
JsonObject params = new JsonObject();
8185
params.addProperty("timeNumber", time);
82-
browserContext.sendMessage("clockSetFixedTime", params);
86+
sendMessageWithLogging("clockSetFixedTime", params);
8387
}
8488

8589
@Override
8690
public void setFixedTime(String time) {
8791
JsonObject params = new JsonObject();
8892
params.addProperty("timeString", time);
89-
browserContext.sendMessage("clockSetFixedTime", params);
93+
sendMessageWithLogging("clockSetFixedTime", params);
9094
}
9195

9296
@Override
9397
public void setFixedTime(Date time) {
9498
JsonObject params = new JsonObject();
9599
params.addProperty("timeNumber", time.getTime());
96-
browserContext.sendMessage("clockSetFixedTime", params);
100+
sendMessageWithLogging("clockSetFixedTime", params);
97101
}
98102

99103
@Override
100104
public void setSystemTime(long time) {
101105
JsonObject params = new JsonObject();
102106
params.addProperty("timeNumber", time);
103-
browserContext.sendMessage("clockSetSystemTime", params);
107+
sendMessageWithLogging("clockSetSystemTime", params);
104108
}
105109

106110
@Override
107111
public void setSystemTime(String time) {
108112
JsonObject params = new JsonObject();
109113
params.addProperty("timeString", time);
110-
browserContext.sendMessage("clockSetSystemTime", params);
114+
sendMessageWithLogging("clockSetSystemTime", params);
111115
}
112116

113117
@Override
114118
public void setSystemTime(Date time) {
115119
JsonObject params = new JsonObject();
116120
params.addProperty("timeNumber", time.getTime());
117-
browserContext.sendMessage("clockSetSystemTime", params);
121+
sendMessageWithLogging("clockSetSystemTime", params);
118122
}
119123

120124
private static void parseTime(Object time, JsonObject params) {

0 commit comments

Comments
 (0)