File tree Expand file tree Collapse file tree 2 files changed +6
-6
lines changed Expand file tree Collapse file tree 2 files changed +6
-6
lines changed Original file line number Diff line number Diff line change @@ -251,7 +251,7 @@ async def test_page_route_should_be_abortable_with_custom_error_codes(
251
251
assert len (failed_requests ) == 1
252
252
failed_request = failed_requests [0 ]
253
253
if is_webkit :
254
- assert failed_request .failure == "Request intercepted "
254
+ assert failed_request .failure == "Blocked by Web Inspector "
255
255
elif is_firefox :
256
256
assert failed_request .failure == "NS_ERROR_OFFLINE"
257
257
else :
@@ -277,7 +277,7 @@ async def test_page_route_should_fail_navigation_when_aborting_main_resource(
277
277
await page .goto (server .EMPTY_PAGE )
278
278
assert exc
279
279
if is_webkit :
280
- assert "Request intercepted " in exc .value .message
280
+ assert "Blocked by Web Inspector " in exc .value .message
281
281
elif is_firefox :
282
282
assert "NS_ERROR_FAILURE" in exc .value .message
283
283
else :
Original file line number Diff line number Diff line change @@ -85,15 +85,17 @@ def on_web_socket(ws):
85
85
86
86
87
87
async def test_should_emit_binary_frame_events (page , ws_server ):
88
+ done_task = asyncio .Future ()
88
89
sent = []
89
90
received = []
90
91
91
92
def on_web_socket (ws ):
92
93
ws .on ("framesent" , lambda payload : sent .append (payload ))
93
94
ws .on ("framereceived" , lambda payload : received .append (payload ))
95
+ ws .on ("close" , lambda : done_task .set_result (None ))
94
96
95
97
page .on ("websocket" , on_web_socket )
96
- async with page .expect_event ("websocket" ) as ws_info :
98
+ async with page .expect_event ("websocket" ):
97
99
await page .evaluate (
98
100
"""port => {
99
101
const ws = new WebSocket('ws://localhost:' + port + '/ws');
@@ -107,9 +109,7 @@ def on_web_socket(ws):
107
109
}""" ,
108
110
ws_server .PORT ,
109
111
)
110
- ws = await ws_info .value
111
- if not ws .is_closed ():
112
- await ws .wait_for_event ("close" )
112
+ await done_task
113
113
assert sent == [b"\x00 \x01 \x02 \x03 \x04 " , "echo-bin" ]
114
114
assert received == ["incoming" , b"\x04 \x02 " ]
115
115
You can’t perform that action at this time.
0 commit comments