Skip to content

Commit 4ccde4a

Browse files
authored
test: fix WebKit tests (#1328)
1 parent 50fbc75 commit 4ccde4a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/async/test_interception.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ async def test_page_route_should_be_abortable_with_custom_error_codes(
251251
assert len(failed_requests) == 1
252252
failed_request = failed_requests[0]
253253
if is_webkit:
254-
assert failed_request.failure == "Request intercepted"
254+
assert failed_request.failure == "Blocked by Web Inspector"
255255
elif is_firefox:
256256
assert failed_request.failure == "NS_ERROR_OFFLINE"
257257
else:
@@ -277,7 +277,7 @@ async def test_page_route_should_fail_navigation_when_aborting_main_resource(
277277
await page.goto(server.EMPTY_PAGE)
278278
assert exc
279279
if is_webkit:
280-
assert "Request intercepted" in exc.value.message
280+
assert "Blocked by Web Inspector" in exc.value.message
281281
elif is_firefox:
282282
assert "NS_ERROR_FAILURE" in exc.value.message
283283
else:

tests/async/test_websocket.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,15 +85,17 @@ def on_web_socket(ws):
8585

8686

8787
async def test_should_emit_binary_frame_events(page, ws_server):
88+
done_task = asyncio.Future()
8889
sent = []
8990
received = []
9091

9192
def on_web_socket(ws):
9293
ws.on("framesent", lambda payload: sent.append(payload))
9394
ws.on("framereceived", lambda payload: received.append(payload))
95+
ws.on("close", lambda: done_task.set_result(None))
9496

9597
page.on("websocket", on_web_socket)
96-
async with page.expect_event("websocket") as ws_info:
98+
async with page.expect_event("websocket"):
9799
await page.evaluate(
98100
"""port => {
99101
const ws = new WebSocket('ws://localhost:' + port + '/ws');
@@ -107,9 +109,7 @@ def on_web_socket(ws):
107109
}""",
108110
ws_server.PORT,
109111
)
110-
ws = await ws_info.value
111-
if not ws.is_closed():
112-
await ws.wait_for_event("close")
112+
await done_task
113113
assert sent == [b"\x00\x01\x02\x03\x04", "echo-bin"]
114114
assert received == ["incoming", b"\x04\x02"]
115115

0 commit comments

Comments
 (0)