Skip to content

Commit 7db9d6b

Browse files
authored
test: unflake test_assertions_page_to_have_{title,url} (#1340)
Fixes #1275
1 parent 869e5f5 commit 7db9d6b

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

tests/async/test_assertions.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,16 @@ async def test_assertions_page_to_have_title(page: Page, server: Server) -> None
2727
await expect(page).to_have_title("new title")
2828
await expect(page).to_have_title(re.compile("new title"))
2929
with pytest.raises(AssertionError):
30-
await expect(page).to_have_title("not the current title", timeout=100)
30+
await expect(page).to_have_title("not the current title", timeout=750)
3131
with pytest.raises(AssertionError):
3232
await expect(page).to_have_title(
33-
re.compile("not the current title"), timeout=100
33+
re.compile("not the current title"), timeout=750
3434
)
3535
with pytest.raises(AssertionError):
36-
await expect(page).not_to_have_title(re.compile("new title"), timeout=100)
36+
await expect(page).not_to_have_title(re.compile("new title"), timeout=750)
3737
with pytest.raises(AssertionError):
38-
await expect(page).not_to_have_title("new title", timeout=100)
39-
await expect(page).not_to_have_title("great title", timeout=100)
38+
await expect(page).not_to_have_title("new title", timeout=750)
39+
await expect(page).not_to_have_title("great title", timeout=750)
4040
await page.evaluate(
4141
"""
4242
setTimeout(() => {
@@ -53,9 +53,9 @@ async def test_assertions_page_to_have_url(page: Page, server: Server) -> None:
5353
await expect(page).to_have_url(server.EMPTY_PAGE)
5454
await expect(page).to_have_url(re.compile(r".*/empty\.html"))
5555
with pytest.raises(AssertionError):
56-
await expect(page).to_have_url("nooooo", timeout=100)
56+
await expect(page).to_have_url("nooooo", timeout=750)
5757
with pytest.raises(AssertionError):
58-
await expect(page).to_have_url(re.compile("not-the-url"), timeout=100)
58+
await expect(page).to_have_url(re.compile("not-the-url"), timeout=750)
5959
await page.evaluate(
6060
"""
6161
setTimeout(() => {
@@ -64,13 +64,13 @@ async def test_assertions_page_to_have_url(page: Page, server: Server) -> None:
6464
"""
6565
)
6666
await expect(page).to_have_url(server.PREFIX + "/grid.html")
67-
await expect(page).not_to_have_url(server.EMPTY_PAGE, timeout=100)
67+
await expect(page).not_to_have_url(server.EMPTY_PAGE, timeout=750)
6868
with pytest.raises(AssertionError):
69-
await expect(page).not_to_have_url(re.compile(r".*/grid\.html"), timeout=100)
69+
await expect(page).not_to_have_url(re.compile(r".*/grid\.html"), timeout=750)
7070
with pytest.raises(AssertionError):
71-
await expect(page).not_to_have_url(server.PREFIX + "/grid.html", timeout=100)
71+
await expect(page).not_to_have_url(server.PREFIX + "/grid.html", timeout=750)
7272
await expect(page).to_have_url(re.compile(r".*/grid\.html"))
73-
await expect(page).not_to_have_url("**/empty.html", timeout=100)
73+
await expect(page).not_to_have_url("**/empty.html", timeout=750)
7474

7575

7676
async def test_assertions_page_to_have_url_with_base_url(

tests/sync/test_assertions.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ def test_assertions_page_to_have_title(page: Page, server: Server) -> None:
2727
expect(page).to_have_title("new title")
2828
expect(page).to_have_title(re.compile("new title"))
2929
with pytest.raises(AssertionError):
30-
expect(page).to_have_title("not the current title", timeout=100)
30+
expect(page).to_have_title("not the current title", timeout=750)
3131
with pytest.raises(AssertionError):
32-
expect(page).to_have_title(re.compile("not the current title"), timeout=100)
32+
expect(page).to_have_title(re.compile("not the current title"), timeout=750)
3333
with pytest.raises(AssertionError):
34-
expect(page).not_to_have_title(re.compile("new title"), timeout=100)
34+
expect(page).not_to_have_title(re.compile("new title"), timeout=750)
3535
with pytest.raises(AssertionError):
36-
expect(page).not_to_have_title("new title", timeout=100)
37-
expect(page).not_to_have_title("great title", timeout=100)
36+
expect(page).not_to_have_title("new title", timeout=750)
37+
expect(page).not_to_have_title("great title", timeout=750)
3838
page.evaluate(
3939
"""
4040
setTimeout(() => {
@@ -51,9 +51,9 @@ def test_assertions_page_to_have_url(page: Page, server: Server) -> None:
5151
expect(page).to_have_url(server.EMPTY_PAGE)
5252
expect(page).to_have_url(re.compile(r".*/empty\.html"))
5353
with pytest.raises(AssertionError):
54-
expect(page).to_have_url("nooooo", timeout=100)
54+
expect(page).to_have_url("nooooo", timeout=750)
5555
with pytest.raises(AssertionError):
56-
expect(page).to_have_url(re.compile("not-the-url"), timeout=100)
56+
expect(page).to_have_url(re.compile("not-the-url"), timeout=750)
5757
page.evaluate(
5858
"""
5959
setTimeout(() => {
@@ -62,13 +62,13 @@ def test_assertions_page_to_have_url(page: Page, server: Server) -> None:
6262
"""
6363
)
6464
expect(page).to_have_url(server.PREFIX + "/grid.html")
65-
expect(page).not_to_have_url(server.EMPTY_PAGE, timeout=100)
65+
expect(page).not_to_have_url(server.EMPTY_PAGE, timeout=750)
6666
with pytest.raises(AssertionError):
67-
expect(page).not_to_have_url(re.compile(r".*/grid\.html"), timeout=100)
67+
expect(page).not_to_have_url(re.compile(r".*/grid\.html"), timeout=750)
6868
with pytest.raises(AssertionError):
69-
expect(page).not_to_have_url(server.PREFIX + "/grid.html", timeout=100)
69+
expect(page).not_to_have_url(server.PREFIX + "/grid.html", timeout=750)
7070
expect(page).to_have_url(re.compile(r".*/grid\.html"))
71-
expect(page).not_to_have_url("**/empty.html", timeout=100)
71+
expect(page).not_to_have_url("**/empty.html", timeout=750)
7272

7373

7474
def test_assertions_page_to_have_url_with_base_url(

0 commit comments

Comments
 (0)