tests: added download tests and linting (#43)

Author: mxschmitt

.github/workflows/ci.yml

@@ -40,7 +40,10 @@ jobs:
         pip install -r local-requirements.txt
         pip install .
     - name: Lint
-      run: black --check .
+      run: |
+        black --check .
+        mypy .
+        flake8  playwright tests
     - name: Build driver
       run: python build_driver.py
       env:

.pre-commit-config.yaml

@@ -16,3 +16,7 @@ repos:
     rev: v0.782
     hooks:
     -   id: mypy
+-   repo: https://gitlab.com/pycqa/flake8
+    rev: 'a7be77f761a4c29121d6bb6f61c11902281f9105'
+    hooks:
+    -   id: flake8

local-requirements.txt

@@ -9,3 +9,4 @@ twisted==20.3.0
 wheel==0.34.2
 black==19.10b0
 pre-commit==2.6.0
+flake8==3.8.3

playwright/accessibility.py

@@ -13,7 +13,6 @@
 # limitations under the License.
 
 from playwright.connection import Channel
-from playwright.helper import locals_to_params
 from playwright.element_handle import ElementHandle
 from typing import Dict
 

playwright/browser.py

@@ -14,11 +14,11 @@
 
 import sys
 from playwright.browser_context import BrowserContext
-from playwright.connection import Channel, ChannelOwner, ConnectionScope, from_channel
+from playwright.connection import ChannelOwner, ConnectionScope, from_channel
 from playwright.helper import locals_to_params, ColorScheme
 from playwright.page import Page
 from types import SimpleNamespace
-from typing import Dict, List, Optional, Union
+from typing import Dict, List, Union
 
 if sys.version_info >= (3, 8):
     from typing import Literal

playwright/browser_context.py

@@ -14,11 +14,9 @@
 
 import asyncio
 from playwright.connection import (
-    Channel,
     ChannelOwner,
     ConnectionScope,
     from_channel,
-    from_nullable_channel,
 )
 from playwright.helper import (
     Cookie,
@@ -31,7 +29,7 @@
     URLMatch,
     URLMatcher,
 )
-from playwright.network import Request, Response, Route
+from playwright.network import Request, Route
 from playwright.page import BindingCall, Page
 from types import SimpleNamespace
 from typing import Any, Callable, Dict, List, Optional, Union, TYPE_CHECKING

playwright/browser_server.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from playwright.connection import Channel, ChannelOwner, ConnectionScope
+from playwright.connection import ChannelOwner, ConnectionScope
 from types import SimpleNamespace
 from typing import Dict
 

playwright/browser_type.py

@@ -12,11 +12,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from playwright.connection import Channel, ChannelOwner, ConnectionScope, from_channel
+from playwright.connection import ChannelOwner, ConnectionScope, from_channel
 from playwright.browser import Browser
 from playwright.browser_context import BrowserContext
 from playwright.helper import locals_to_params, ColorScheme
-from typing import Awaitable, Dict, List
+from typing import Dict, List
 
 
 class BrowserType(ChannelOwner):

playwright/connection.py

@@ -16,7 +16,7 @@
 from playwright.helper import parse_error, ParsedMessagePayload
 from playwright.transport import Transport
 from pyee import BaseEventEmitter
-from typing import Any, Awaitable, Dict, List, Optional
+from typing import Any, Dict, List, Optional
 
 
 class Channel(BaseEventEmitter):

playwright/console_message.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from playwright.connection import Channel, ChannelOwner, ConnectionScope, from_channel
+from playwright.connection import ChannelOwner, ConnectionScope, from_channel
 from playwright.helper import ConsoleMessageLocation
 from playwright.js_handle import JSHandle
 from typing import Dict, List