impl 37996

Author: Skn0tt

playwright/_impl/_glob.py

@@ -28,12 +28,21 @@ def glob_to_regex_pattern(glob: str) -> str:
             tokens.append("\\" + char if char in escaped_chars else char)
             i += 1
         elif c == "*":
+            char_before = glob[i - 1] if i > 0 else None
             star_count = 1
             while i + 1 < len(glob) and glob[i + 1] == "*":
                 star_count += 1
                 i += 1
             if star_count > 1:
-                tokens.append("(.*)")
+                char_after = glob[i + 1] if i + 1 < len(glob) else None
+                if char_after == "/":
+                    if char_before == "/":
+                        tokens.append("((.+/)|)")
+                    else:
+                        tokens.append("(.*/)")
+                    i += 1
+                else:
+                    tokens.append("(.*)")
             else:
                 tokens.append("([^/]*)")
         else:

tests/async/test_page_route.py

@@ -1083,6 +1083,10 @@ def glob_to_regex(pattern: str) -> re.Pattern:
         "http://localhost:3000/signin-oidcnice"
     )
 
+    assert glob_to_regex("**/*.js").match("/foo.js")
+    assert not glob_to_regex("asd/**.js").match("/foo.js")
+    assert not glob_to_regex("**/*.js").match("bar_foo.js")
+
     # range [] is NOT supported
     assert glob_to_regex("**/api/v[0-9]").fullmatch("http://example.com/api/v[0-9]")
     assert not glob_to_regex("**/api/v[0-9]").fullmatch(
@@ -1174,6 +1178,10 @@ def glob_to_regex(pattern: str) -> re.Pattern:
     assert url_matches("http://first.host/", "http://second.host/foo", "**/foo")
     assert url_matches("http://playwright.dev/", "http://localhost/", "*//localhost/")
 
+    # /**/ should match /.
+    assert url_matches(None, "https://foo/bar.js", "https://foo/**/bar.js")
+    assert url_matches(None, "https://foo/bar.js", "https://foo/**/**/bar.js")
+
     custom_prefixes = ["about", "data", "chrome", "edge", "file"]
     for prefix in custom_prefixes:
         assert url_matches(