Skip to content

Commit 34cb358

Browse files
authored
chore(bidi): simplify launcher tests for Firefox (#34405)
1 parent a06600a commit 34cb358

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,3 @@ test-results
3535
.cache/
3636
.eslintcache
3737
playwright.env
38-
firefox

tests/library/firefox/launcher.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ it('should pass firefox user preferences', async ({ browserType, mode }) => {
2121
const browser = await browserType.launch({
2222
firefoxUserPrefs: {
2323
'network.proxy.type': 1,
24-
'network.proxy.http': '127.0.0.1',
25-
'network.proxy.http_port': 3333,
24+
'network.proxy.ssl': '127.0.0.1',
25+
'network.proxy.ssl_port': 3333,
2626
}
2727
});
2828
const page = await browser.newPage();
29-
const error = await page.goto('http://example.com').catch(e => e);
29+
const error = await page.goto('https://example.com').catch(e => e);
3030
expect(error.message).toContain('NS_ERROR_PROXY_CONNECTION_REFUSED');
3131
await browser.close();
3232
});
@@ -36,10 +36,10 @@ it('should pass firefox user preferences in persistent', async ({ mode, launchPe
3636
const { page } = await launchPersistent({
3737
firefoxUserPrefs: {
3838
'network.proxy.type': 1,
39-
'network.proxy.http': '127.0.0.1',
40-
'network.proxy.http_port': 3333,
39+
'network.proxy.ssl': '127.0.0.1',
40+
'network.proxy.ssl_port': 3333,
4141
}
4242
});
43-
const error = await page.goto('http://example.com').catch(e => e);
43+
const error = await page.goto('https://example.com').catch(e => e);
4444
expect(error.message).toContain('NS_ERROR_PROXY_CONNECTION_REFUSED');
4545
});

0 commit comments

Comments
 (0)