Skip to content

Commit d9402ae

Browse files
committed
chore: fix roll_broser script
1 parent 428f196 commit d9402ae

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

utils/roll_browser.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ Example:
6060
'ff-beta': 'firefox-beta',
6161
'wk': 'webkit',
6262
}[args[0].toLowerCase()] ?? args[0].toLowerCase();
63-
const descriptors = [browsersJSON.browsers.find(b => b.name === browserName)];
63+
const descriptors = browsersJSON.browsers.filter(b =>
64+
b.name === browserName || `${browserName}-headless-shell` === b.name
65+
);
6466

6567
if (!descriptors.every(d => !!d)) {
6668
console.log(`Unknown browser "${browserName}"`);
@@ -94,18 +96,6 @@ Example:
9496
console.log('\nUpdating browser version in browsers.json...');
9597
for (const descriptor of descriptors)
9698
descriptor.browserVersion = browserVersion;
97-
98-
// 4.1 chromium-headless-shell is equal to chromium version.
99-
if (browserName === 'chromium') {
100-
const headlessShellBrowser = await browsersJSON.browsers.find(b => b.name === 'chromium-headless-shell');
101-
headlessShellBrowser.revision = revision;
102-
headlessShellBrowser.browserVersion = browserVersion;
103-
} else if (browserName === 'chromium-tip-of-tree') {
104-
const tipOfTreeBrowser = await browsersJSON.browsers.find(b => b.name === 'chromium-tip-of-tree-headless-shell');
105-
tipOfTreeBrowser.revision = revision;
106-
tipOfTreeBrowser.browserVersion = browserVersion;
107-
}
108-
10999
fs.writeFileSync(path.join(CORE_PATH, 'browsers.json'), JSON.stringify(browsersJSON, null, 2) + '\n');
110100
}
111101

@@ -118,8 +108,9 @@ Example:
118108
// 6. Update docs.
119109
console.log('\nUpdating documentation...');
120110
try {
121-
process.stdout.write(execSync('npm run --silent doc'));
111+
execSync('npm run doc', { stdio: 'inherit' });
122112
} catch (e) {
113+
console.log('npm run doc failed with non-zero exit code. This might have updated generated files.');
123114
}
124115
}
125116
console.log(`\nRolled ${browserName} to ${revision}`);

0 commit comments

Comments
 (0)