fix: teleEmit onExit #37897
Closed
fix: teleEmit onExit #37897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Oct 17, 2025
| }); | ||
| } | ||
|
|
||
| async onExit() { |
There was a problem hiding this comment.
I am not sure this won't break blob/merge. I suspect there will be multiple onExit calls in the merger now.
There was a problem hiding this comment.
Tests are green. I'll investigate and see if we're missing some.
There was a problem hiding this comment.
It doesn't touch blob/merge, because the blob reporter already emits its report in onEnd. The onExit message goes into the void.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "MCP"2570 passed, 108 skipped Merge workflow run. |
Test results for "tests 1"6 flaky47093 passed, 815 skipped Merge workflow run. |
dgozman
approved these changes
Oct 20, 2025
|
don't seem to need it anymore for microsoft/playwright-vscode#702, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered through microsoft/playwright-vscode#702. We have code for receiving
onExit, but not for emitting.