Skip to content

Commit c4e8451

Browse files
authored
Remove white background from high contrast sim LEDs (#6418)
Previously, we used a white background for the sim LEDs in high contrast mode, I suspect so that it contrasted with the unlit LEDs as well as the lit ones. But it looks a little like a bug...instead of doing it that way, we can use the normal red-on-black appearance (with slightly brighter red) and outline the unlit LEDs with white.
1 parent b51c867 commit c4e8451

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

sim/visuals/microbit.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,9 @@ path.sim-board {
182182
.sim-led {
183183
stroke: red;
184184
}
185+
.sim-led-back {
186+
stroke: white;
187+
}
185188
*:focus .sim-button-outer,
186189
.sim-pin:focus,
187190
.sim-thermometer:focus,
@@ -286,9 +289,8 @@ path.sim-board {
286289
if (highContrast) {
287290
theme = JSON.parse(JSON.stringify(theme)) as IBoardTheme;
288291
theme.highContrast = true;
289-
theme.ledOff = "#888";
290-
theme.ledOn = "#0000bb";
291-
theme.display = "#ffffff";
292+
theme.ledOff = "#000000";
293+
theme.ledOn = "#FF0000";
292294
theme.pin = "#D4AF37";
293295
theme.accent = "#FFD43A";
294296
}

0 commit comments

Comments
 (0)