localize type names and add react-common to strings

Author: riknoll

cli/cli.ts

@@ -1830,6 +1830,9 @@ function saveThemeJson(cfg: pxt.TargetBundle, localDir?: boolean, packaged?: boo
             if (extraType.label) {
                 targetStrings[`{id:type}${extraType.label}`] = extraType.label;
             }
+            else {
+                targetStrings[`{id:type}${extraType.typeName}`] = extraType.typeName;
+            }
 
             if (extraType.defaultName) {
                 targetStrings[`{id:var}${extraType.defaultName}`] = extraType.defaultName;

gulpfile.js

@@ -235,6 +235,7 @@ function updatestrings() {
         "pxtpy",
         "pxtsim",
         "webapp/src",
+        "react-common"
     ], true);
 }
 

webapp/src/createFunction.tsx

@@ -212,18 +212,19 @@ export class CreateFunctionDialog extends data.Component<ISettingsProps, CreateF
                 }
             ];
 
-            if (pxt.appTarget.runtime &&
-                pxt.appTarget.runtime.functionsOptions &&
-                pxt.appTarget.runtime.functionsOptions.extraFunctionEditorTypes &&
-                Array.isArray(pxt.appTarget.runtime.functionsOptions.extraFunctionEditorTypes)) {
+            const extraTypes = pxt.appTarget.runtime?.functionsOptions?.extraFunctionEditorTypes;
+
+            if (Array.isArray(extraTypes)) {
+                for (const extraType of extraTypes) {
+                    const label = extraType.label || extraType.typeName;
+                    const defaultName = extraType.defaultName;
 
-                pxt.appTarget.runtime.functionsOptions.extraFunctionEditorTypes.forEach(t => {
                     types.push({
-                        ...t,
-                        label: t.label && pxt.Util.rlf(`{id:type}${t.label}`),
-                        defaultName: t.defaultName && pxt.Util.rlf(`{id:var}${t.defaultName}`)
-                    })
-                });
+                        ...extraType,
+                        label: pxt.Util.rlf(`{id:type}${label}`),
+                        defaultName: defaultName && pxt.Util.rlf(`{id:var}${defaultName}`)
+                    });
+                }
             }
 
             types.forEach(t => {