Skip to content

Add Pixi locator #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 9, 2024
Merged

Add Pixi locator #172

merged 5 commits into from
Dec 9, 2024

Conversation

@renan-r-santos
Copy link
Contributor

@renan-r-santos renan-r-santos commented Nov 13, 2024 •
edited
Loading

Fixes #46

I'd like to reopen the discussion about adding support for Pixi given the community interest after the above issue was closed and to bring feature parity with the js locator.
Because Pixi environments have a unique directory layout, the proposed solution is simple enough that it doesn't need any process spawning.

Sister PR:

@renan-r-santos
Copy link
Contributor Author

renan-r-santos commented Nov 13, 2024

@microsoft-github-policy-service agree

@renan-r-santos renan-r-santos marked this pull request as ready for review November 13, 2024 23:49
@renan-r-santos renan-r-santos mentioned this pull request Nov 13, 2024
Merged
@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Nov 18, 2024
@renan-r-santos
Copy link
Contributor Author

renan-r-santos commented Nov 19, 2024 •
edited
Loading

@karthiknadig I added a commit based on #175 to fix the unrelated Homebrew CI issue. Even if brew update fails, running it somehow fixes the subsequent brew install. I also confirmed the issue only happens on Homebrew 4.4.6, released ~16 hours ago. Any Homebrew image <=4.4.5 works fine but I couldn't pinpoint the upstream commit causing the issue.
Let me know if this change is ok or if you prefer pinning the Homebrew image or something else.

@karthiknadig
Copy link
Member

karthiknadig commented Nov 19, 2024

Thanks for the fix. What you have is good. May be a comment in the YML and docker file, since it looks odd that we are doing this. Also it will remind us to remove it in the future.

DonJayamanne
DonJayamanne reviewed Nov 19, 2024
View reviewed changes
crates/pet/README.md
These are always stored in a custom (global) lcoation.
5. Conda

5. Pixi
Copy link
Collaborator

@DonJayamanne DonJayamanne Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome,

@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 20, 2024
karthiknadig pushed a commit to microsoft/vscode-python that referenced this pull request Nov 26, 2024
@renan-r-santos
Add native Pixi locator (#24442)
4f7165f 
Sister PR (needs to be merged first):
- microsoft/python-environment-tools#172
@karthiknadig karthiknadig merged commit 15124b5 into microsoft:main Dec 9, 2024
20 checks passed
@chanderson0 chanderson0 mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

@anthonykim1 anthonykim1 anthonykim1 approved these changes

Assignees

@karthiknadig karthiknadig

Labels

feature-request Request for new features or functionality

Projects

None yet

Milestone

November 2024

Development

Successfully merging this pull request may close these issues.

Add support for pixi

4 participants

@renan-r-santos @karthiknadig @DonJayamanne @anthonykim1