Skip to content

Commit 3dc5a7d

Browse files
fix: typo in integration documentation: 'userd' -> 'used' (#2034)
* Fix typo in integration docs: 'userd' -> 'used' * fix: pylint error in CI --------- Co-authored-by: Linlang <[email protected]>
1 parent 7d66e4b commit 3dc5a7d

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

docs/start/integration.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ The Custom models need to inherit `qlib.model.base.Model <../reference/api.html#
7171
)
7272
7373
- Override the `predict` method
74-
- The parameters must include the parameter `dataset`, which will be userd to get the test dataset.
74+
- The parameters must include the parameter `dataset`, which will be used to get the test dataset.
7575
- Return the `prediction score`.
7676
- Please refer to `Model API <../reference/api.html#module-qlib.model.base>`_ for the parameter types of the fit method.
7777
- Code Example: In the following example, users need to use `LightGBM` to predict the label(such as `preds`) of test data `x_test` and return it.

scripts/data_collector/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def _get_calendar(url):
8282
if bench_code.upper() == "ALL":
8383

8484
@deco_retry
85-
def _get_calendar(month):
85+
def _get_calendar_from_month(month):
8686
_cal = []
8787
try:
8888
resp = requests.get(
@@ -98,7 +98,7 @@ def _get_calendar(month):
9898
month_range = pd.date_range(start="2000-01", end=pd.Timestamp.now() + pd.Timedelta(days=31), freq="M")
9999
calendar = []
100100
for _m in month_range:
101-
cal = _get_calendar(_m.strftime("%Y-%m"))
101+
cal = _get_calendar_from_month(_m.strftime("%Y-%m"))
102102
if cal:
103103
calendar += cal
104104
calendar = list(filter(lambda x: x <= pd.Timestamp.now(), calendar))

scripts/data_collector/yahoo/collector.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -613,10 +613,6 @@ def adjusted_price(self, df: pd.DataFrame) -> pd.DataFrame:
613613
def symbol_to_yahoo(self, symbol):
614614
raise NotImplementedError("rewrite symbol_to_yahoo")
615615

616-
@abc.abstractmethod
617-
def _get_1d_calendar_list(self) -> Iterable[pd.Timestamp]:
618-
raise NotImplementedError("rewrite _get_1d_calendar_list")
619-
620616

621617
class YahooNormalizeUS:
622618
def _get_calendar_list(self) -> Iterable[pd.Timestamp]:

0 commit comments

Comments
 (0)